feat: Validate OIDC ID token during Sentry OAuth flow #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #52 +/- ##
=======================================
+ Coverage 95.34 95.59 +0.25
=======================================
Files 702 701 -1
Lines 14932 14907 -25
=======================================
+ Hits 14236 14249 +13
+ Misses 696 658 -38
Flags with carried forward coverage won't be shown. Click here to find out more.
|
matt-codecov
approved these changes
Aug 2, 2023
* main: (58 commits) Adding beginnings of GHA CI (#127) feat: Filter flags by flags for pathContents (#128) Create checkbox in Owner form in Django admin to set uses_invoice (#109) build(deps): bump certifi from 2020.6.20 to 2023.7.22 (#32) Feature/no compile (#126) Bump django from 4.2.2 to 4.2.3 (#42) Don't compile since source is available (#106) feat: Add firstPull resolver to GraphQL pull type (#108) chore: Upgrade requests and redis dependencies (#124) Update LICENSE (#122) Attempt migration (#121) 359 adjust monthly uploads for trialled customers (#119) Add changes for monthly uploads to account for trialing customer (#101) Adjust donwload_url link (#115) update to handle to redirects (#113) fix: Include impacted files with no coverage diff and no indirect changes in direct changes list (#114) Make uses_invoice field on Owner(#92) feat: support gh refresh tokens (#85) Add RiskyAlterField to utils/migrations (#93) Fix/config error enterprise (#107) ...
scott-codecov
force-pushed
the
scott/sentry-oidc
branch
from
7b91b6a
to
10cb19d
Compare
scott-codecov
added a commit
that referenced
this pull request
Sep 14, 2023
* main: (74 commits) Fix indentation error (#133) Add cache cleanup (#130) Feature/lint pre commit (#134) feat: trigger label analysis task after update (#131) Filter file comparisons by flags (#129) chore: Remove hard-coded dev BB redirect URL (#132) feat: Validate OIDC ID token during Sentry OAuth flow (#52) Adding beginnings of GHA CI (#127) feat: Filter flags by flags for pathContents (#128) Create checkbox in Owner form in Django admin to set uses_invoice (#109) build(deps): bump certifi from 2020.6.20 to 2023.7.22 (#32) Feature/no compile (#126) Bump django from 4.2.2 to 4.2.3 (#42) Don't compile since source is available (#106) feat: Add firstPull resolver to GraphQL pull type (#108) chore: Upgrade requests and redis dependencies (#124) Update LICENSE (#122) Attempt migration (#121) 359 adjust monthly uploads for trialled customers (#119) Add changes for monthly uploads to account for trialing customer (#101) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We request an
oidcscope during the OAuth flow with Sentry which results in anid_tokenbeing present in the/oauth/tokenresponse. This token is a JWT which is signed using a shared secret and can be used to verify that it was indeed Sentry who sent us the token response.