Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump idna from 2.8 to 3.7 #524

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Conversation

ajay-sentry
Copy link
Contributor

Purpose/Motivation

Dependency update to fix GHSA-jjg7-2v4v-x38h

changelog

Links to relevant tickets

Closes https://github.com/codecov/internal-issues/issues/414

What does this PR do?

updated dependency to 3.7 from 2.8. Added to requirements.in and ran pip-compile.

Notes to Reviewer

Anything to note to the team? Any tips on how to review, or where to start?

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found ☺️

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.45%. Comparing base (5f242b9) to head (d47ffd7).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #524      +/-   ##
==========================================
- Coverage   91.45%   91.45%   -0.01%     
==========================================
  Files         599      599              
  Lines       16212    16211       -1     
==========================================
- Hits        14826    14825       -1     
  Misses       1386     1386              
Flag Coverage Δ
unit 91.45% <ø> (-0.01%) ⬇️
unit-latest-uploader 91.45% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.45%. Comparing base (5f242b9) to head (d47ffd7).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #524      +/-   ##
==========================================
- Coverage   91.45%   91.45%   -0.01%     
==========================================
  Files         599      599              
  Lines       16212    16211       -1     
==========================================
- Hits        14826    14825       -1     
  Misses       1386     1386              
Flag Coverage Δ
unit 91.45% <ø> (-0.01%) ⬇️
unit-latest-uploader 91.45% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Impacted file tree graph

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.75%. Comparing base (5f242b9) to head (d47ffd7).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #524     +/-   ##
=======================================
- Coverage   95.76   95.75   -0.01     
=======================================
  Files        774     774             
  Lines      17068   17157     +89     
=======================================
+ Hits       16345   16428     +83     
- Misses       723     729      +6     
Flag Coverage Δ
unit 91.45% <ø> (-0.01%) ⬇️
unit-latest-uploader 91.45% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ajay-sentry ajay-sentry added this pull request to the merge queue Apr 25, 2024
Merged via the queue into main with commit 9570180 Apr 25, 2024
17 of 21 checks passed
@ajay-sentry ajay-sentry deleted the Ajay/dependency-updates branch April 25, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants