add rate limit error handling to TokenlessGithubActionsHandler #525
Conversation
| repo_name=self.upload_params.get("repo"), | ||
| time_diff=now - finish_time_with_buffer, | ||
| ), | ||
| ) |
There was a problem hiding this comment.
removed this because it looked like the exact same warning was being logged twice, seems like an accident.
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #525 +/- ##
=======================================
Coverage 91.45% 91.45%
=======================================
Files 599 599
Lines 16211 16222 +11
=======================================
+ Hits 14825 14836 +11
Misses 1386 1386
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #525 +/- ##
=======================================
+ Coverage 95.76 95.77 +0.01
=======================================
Files 774 774
Lines 17067 17078 +11
=======================================
+ Hits 16344 16355 +11
Misses 723 723
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Purpose/Motivation
Better errors for users
Links to relevant tickets
codecov/engineering-team#1547
What does this PR do?
Hitting the rate limit for tokenless upload is a special case, adds special handling for this special case, and makes the upload failure more clear to the end user.