Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add has-seats-left to plan query #528

Merged
merged 3 commits into from
May 2, 2024
Merged

feat: Add has-seats-left to plan query #528

merged 3 commits into from
May 2, 2024

Conversation

RulaKhaled
Copy link
Contributor

Purpose/Motivation

What is the feature? Why is this being done?
Making it easy for the client to check if a plan has seats left or not.

Links to relevant tickets

codecov/engineering-team#1318

What does this PR do?

Include a brief description of the changes in this PR. Bullet points are your friend.

Notes to Reviewer

Anything to note to the team? Any tips on how to review, or where to start?

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@RulaKhaled RulaKhaled requested a review from a team as a code owner April 30, 2024 11:49
@codecov-qa
Copy link

codecov-qa bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.52%. Comparing base (03b5754) to head (2fa3ca6).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #528   +/-   ##
=======================================
  Coverage   91.51%   91.52%           
=======================================
  Files         602      602           
  Lines       16352    16367   +15     
=======================================
+ Hits        14965    14980   +15     
  Misses       1387     1387           
Flag Coverage Δ
unit 91.52% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 91.52% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov-public-qa bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.52%. Comparing base (03b5754) to head (2fa3ca6).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #528   +/-   ##
=======================================
  Coverage   91.51%   91.52%           
=======================================
  Files         602      602           
  Lines       16352    16367   +15     
=======================================
+ Hits        14965    14980   +15     
  Misses       1387     1387           
Flag Coverage Δ
unit 91.52% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 91.52% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
graphql_api/types/plan/plan.py 98.43% <100.00%> (+0.10%) ⬆️
plan/service.py 96.26% <100.00%> (+0.08%) ⬆️
plan/test_plan.py 100.00% <100.00%> (ø)

Impacted file tree graph

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.80%. Comparing base (03b5754) to head (2fa3ca6).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #528     +/-   ##
=======================================
+ Coverage   95.79   95.80   +0.01     
=======================================
  Files        777     777             
  Lines      17208   17223     +15     
=======================================
+ Hits       16484   16499     +15     
  Misses       724     724             
Flag Coverage Δ
unit 91.52% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 91.52% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RulaKhaled RulaKhaled added this pull request to the merge queue Apr 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 30, 2024
@RulaKhaled RulaKhaled added this pull request to the merge queue May 2, 2024
Merged via the queue into main with commit 5208a04 May 2, 2024
19 checks passed
@RulaKhaled RulaKhaled deleted the has-seats-left branch May 2, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants