Bundle analysis: Fetch trend measurements #612
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #612 +/- ##
==========================================
+ Coverage 91.46% 91.51% +0.04%
==========================================
Files 615 615
Lines 16389 16481 +92
==========================================
+ Hits 14991 15083 +92
Misses 1398 1398
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #612 +/- ##
==========================================
+ Coverage 91.46% 91.51% +0.04%
==========================================
Files 615 615
Lines 16389 16481 +92
==========================================
+ Hits 14991 15083 +92
Misses 1398 1398
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #612 +/- ##
================================================
+ Coverage 95.91000 95.93000 +0.02000
================================================
Files 793 793
Lines 17706 17798 +92
================================================
+ Hits 16983 17075 +92
Misses 723 723
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
|
||
| @cached_property | ||
| def asset_type(self) -> str: | ||
| return self.measurement_type.name |
There was a problem hiding this comment.
Is there value in these properties being in Shared over api? Are these used in worker/the PR comment?
There was a problem hiding this comment.
Shouldn't be needed for worker, unless we want to show trend lines in PR comments some day 😮
Purpose/Motivation
Allow fetching of trends from timeseries for bundle analysis measurements.
closes codecov/engineering-team#1772
closes codecov/engineering-team#1773
closes codecov/engineering-team#1774
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.