Bundle analysis - add GQL schema for filtering and removed deprecated code #617
Conversation
JerrySentry
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #617 +/- ##
==========================================
- Coverage 91.51% 91.48% -0.04%
==========================================
Files 615 615
Lines 16481 16418 -63
==========================================
- Hits 15083 15020 -63
Misses 1398 1398
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #617 +/- ##
==========================================
- Coverage 91.51% 91.48% -0.04%
==========================================
Files 615 615
Lines 16481 16418 -63
==========================================
- Hits 15083 15020 -63
Misses 1398 1398
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #617 +/- ##
================================================
- Coverage 95.93000 95.92000 -0.01000
================================================
Files 793 793
Lines 17798 17735 -63
================================================
- Hits 17075 17012 -63
Misses 723 723
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JerrySentry
changed the title
services/bundle_analysis.py
Outdated
| self.report = report | ||
|
|
||
| # TODO this will be passed to shared.BundleReport in assets and szie_total calls |
closes codecov/engineering-team#1896
Delete some old GQL types that we don't need anymore.
closes codecov/engineering-team#1895
Add in the filters for
BundleAnalysisReport.bundletype, the logic will be coded in shared, doesn't do anything in this PRLegal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.