Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Store "Logged in with" user metrics #626

Merged
merged 8 commits into from
Jun 24, 2024

Conversation

rohitvinnakota-codecov
Copy link
Contributor

@rohitvinnakota-codecov rohitvinnakota-codecov commented Jun 19, 2024

Purpose/Motivation

Eng design: https://www.notion.so/sentry/Eng-Design-Tracking-Codecov-user-signup-to-first-commit-conversion-rate-6097411516f84563820276aafe3436ea

Stores metrics for when users login with a specific provider.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.94%. Comparing base (196de23) to head (2edcbac).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@               Coverage Diff                @@
##               main       #626        +/-   ##
================================================
+ Coverage   95.93000   95.94000   +0.01000     
================================================
  Files           799        799                
  Lines         17807      17813         +6     
================================================
+ Hits          17084      17090         +6     
  Misses          723        723                
Flag Coverage Δ
unit 91.52% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 91.52% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-qa
Copy link

codecov-qa bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.52%. Comparing base (196de23) to head (2edcbac).

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main     #626   +/-   ##
=======================================
  Coverage   91.52%   91.52%           
=======================================
  Files         621      621           
  Lines       16490    16496    +6     
=======================================
+ Hits        15092    15098    +6     
  Misses       1398     1398           
Flag Coverage Δ
unit 91.52% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 91.52% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
codecov_auth/views/bitbucket.py 98.52% <100.00%> (+0.04%) ⬆️
codecov_auth/views/github.py 98.18% <100.00%> (+0.03%) ⬆️
codecov_auth/views/gitlab.py 98.52% <100.00%> (+0.04%) ⬆️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@codecov-notifications
Copy link

codecov-notifications bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

codecov-public-qa bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.52%. Comparing base (196de23) to head (2edcbac).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #626   +/-   ##
=======================================
  Coverage   91.52%   91.52%           
=======================================
  Files         621      621           
  Lines       16490    16496    +6     
=======================================
+ Hits        15092    15098    +6     
  Misses       1398     1398           
Flag Coverage Δ
unit 91.52% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 91.52% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
codecov_auth/views/bitbucket.py 98.52% <100.00%> (+0.04%) ⬆️
codecov_auth/views/github.py 98.18% <100.00%> (+0.03%) ⬆️
codecov_auth/views/gitlab.py 98.52% <100.00%> (+0.04%) ⬆️

Impacted file tree graph

@rohitvinnakota-codecov rohitvinnakota-codecov marked this pull request as ready for review June 20, 2024 14:06
UserOnboardingMetricsService.create_user_onboarding_metric(
org_id=user.ownerid, event="INSTALLED_APP", payload={"login": "gitlab"}
)
print("WE PAST THI")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

print

@rohitvinnakota-codecov rohitvinnakota-codecov added this pull request to the merge queue Jun 24, 2024
Merged via the queue into main with commit 3717c9f Jun 24, 2024
21 of 22 checks passed
@rohitvinnakota-codecov rohitvinnakota-codecov deleted the rvinnakota/store-login-metrics branch June 24, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants