feat: move Pull.flare to storage
#63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage is
☔ View full report in Codecov by Sentry. |
Codecov Report
Changes have been made to critical files, which contain lines commonly executed in production. Learn more @@ Coverage Diff @@
## main #63 +/- ##
=======================================
- Coverage 95.31 95.25 -0.06
=======================================
Files 694 695 +1
Lines 14741 14769 +28
=======================================
+ Hits 14049 14068 +19
- Misses 692 701 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
giovanni-guidini
force-pushed
the
gio/pulls-flare-to-storage
branch
2 times, most recently
from
f0f4537
to
38f8ebb
Compare
giovanni-guidini
requested review from
dana-yaish,
matt-codecov and
scott-codecov
scott-codecov
approved these changes
Aug 15, 2023
This commit is the initial work (+ migration) to move `Pull.flare` to storage. This column has crashed the DB in only 1 occasion in the past. Notice that Pull doesn't have `commit` (because multiple commits refer to the same pull). To deal with that I changed the writing of data to have 2 paths: one with commit, and one without the commit. So pulls data will be written in the repo level (in storage). Part of codecov/engineering-team#70
giovanni-guidini
force-pushed
the
gio/pulls-flare-to-storage
branch
from
baafa50
to
652fdbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is the initial work (+ migration) to move
Pull.flareto storage.This column has crashed the DB in only 1 occasion in the past.
Notice that Pull doesn't have
commit(because multiple commits refer to the same pull)the issue with that is that in
Pull.get_commitidI set it to return"multiple_commits".This should not affect the usage of
ArchiveField, but will make it so that the data iswritten to
/v4/repos/REPO_HASH/commits/multiple_commits/json_data/...It's fine by me, but we might want to consider another solution.
Part of codecov/engineering-team#70
Purpose/Motivation
What is the feature? Why is this being done?
Links to relevant tickets
What does this PR do?
Include a brief description of the changes in this PR. Bullet points are your friend.
Notes to Reviewer
Anything to note to the team? Any tips on how to review, or where to start?
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.