-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make secure_cookie set SESSION_COOKIE_SECURE #68
Conversation
048b6e9
to
376be4d
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
=======================================
Coverage 95.21% 95.21%
=======================================
Files 578 578
Lines 14474 14474
=======================================
+ Hits 13781 13782 +1
+ Misses 693 692 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Codecov Report
@@ Coverage Diff @@
## main #68 +/- ##
=====================================
Coverage 95.27 95.27
=====================================
Files 691 691
Lines 14645 14645
=====================================
+ Hits 13952 13953 +1
+ Misses 693 692 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
from a quick search it looks like this is on in staging but otherwise not referenced? and the default is false in the django docs, so this has the effect of turning it on by default for local and prod. right? do people need to add anything to their codecov.yml to keep their local setups working? do we need to do anything to prepare prod? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved, with the expectation that either:
- you'll change
default=False
and then add opt prod/local environments in when tested - you'll do a little legwork to make sure flipping this to
True
doesn't require any other changes to work correctly
376be4d
to
4a2a9f6
Compare
Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>
Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>
4a2a9f6
to
97606ae
Compare
Purpose/Motivation
Allow the SESSION_COOKIE_SECURE option in Django to be configurable.
Links to relevant tickets
codecov/shared#20
codecov/engineering-team#124
What does this PR do?