fix broken pyyaml dep, update shared commit hash to corresponding sanitized one #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-codecov
requested review from
trent-codecov,
giovanni-guidini,
scott-codecov,
rfox-codecov and
joseph-sentry
eliatcodecov
approved these changes
Jul 18, 2023
Codecov Report
@@ Coverage Diff @@
## main #7 +/- ##
======================================
Coverage ? 95.21
======================================
Files ? 552
Lines ? 13916
Branches ? 0
======================================
Hits ? 13250
Misses ? 666
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cython 3.0 breaks pyyaml. the impending breakage was reported based on alpha Cython versions more than a year ago but it survived to the official release of cython 3.0. i take that as a signal that we shouldn't wait on a clean upstream resolution
it appears the
Dockerfile.requirementswill take effect in developer workflows and CI. if there are other build procedures this doesn't fix, let me knowthe other reason builds fail is because we sanitized the git history of
sharedand the hash we were pointing at was erased. this PR replaces the hash with the corresponding hash from the sanitized history, which was the merge commit for #388 (pre-purge).Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.