Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return a more descriptive response to the user #74

Merged
merged 5 commits into from
Aug 11, 2023

Conversation

dana-yaish
Copy link
Contributor

When running ATS locally, I faced some vague errors. Adding more info to help the user know what's happening

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-staging
Copy link

codecov-staging bot commented Aug 9, 2023

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage Δ
labelanalysis/serializers.py 100.00% <100.00%> (ø)
staticanalysis/serializers.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #74 (41317e4) into main (e2c6b1c) will not change coverage.
The diff coverage is 100.00%.

@@          Coverage Diff          @@
##            main     #74   +/-   ##
=====================================
  Coverage   95.30   95.30           
=====================================
  Files        693     693           
  Lines      14736   14736           
=====================================
  Hits       14044   14044           
  Misses       692     692           
Flag Coverage Δ
unit 95.24% <100.00%> (ø)
unit-latest-uploader 95.24% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
labelanalysis/serializers.py 100.00% <100.00%> (ø)
staticanalysis/serializers.py 100.00% <100.00%> (ø)

Copy link
Contributor

@giovanni-guidini giovanni-guidini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for improving this

@dana-yaish dana-yaish merged commit 3881ed0 into main Aug 11, 2023
12 checks passed
@dana-yaish dana-yaish deleted the dana/improve-ats-logs branch August 11, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants