-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop cache column from repos table #80
Conversation
6d67688
to
96cab3e
Compare
96cab3e
to
5b739ca
Compare
Trent reminded me that we're still running https://github.com/codecov/codecov.io in production to serve some old public API v1 endpoints. We'll need to make sure those don't also rely on In the meantime I wonder if it's possible to remove the field from the model definition but keep the column for now? This would mean Django would stop querying it but leave |
5b739ca
to
dfbc6cd
Compare
Codecov ReportPatch coverage is
☔ View full report in Codecov by Sentry. |
dfbc6cd
to
b7b7315
Compare
Codecov Report
@@ Coverage Diff @@
## main #80 +/- ##
=====================================
Coverage 95.26 95.26
=====================================
Files 695 696 +1
Lines 14776 14780 +4
=====================================
+ Hits 14075 14079 +4
Misses 701 701
Flags with carried forward coverage won't be shown. Click here to find out more.
|
8b1658c
to
91266b7
Compare
91266b7
to
abb85e1
Compare
This commit adds a migration to remove the repos.cache field from Django but not from the table. It does this by using state_operations to remove the field while running a noop SQL migration. Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>
abb85e1
to
bc3104c
Compare
Purpose/Motivation
The cache column is being removed to an issue where it becomes corrupted and it is impossible to run any queries on the row where the column is corrupted.
I think this actually needs to get merged first (this should probably be merged already): #53
Links to relevant tickets
codecov/engineering-team#92
What does this PR do?
makemigrations