Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle FileNotInStorage error when building report #81

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

scott-codecov
Copy link
Contributor

Seems like some very old commits can be missing the chunks file in GCS. We can't really reconstruct a Report instance in that case so we'll just return None (this is similar to worker behavior found here: https://github.com/codecov/worker/blob/d16beed689f0298b7a0fc14a84f06edaae9778a6/services/report/__init__.py#L435)

Fixes codecov/engineering-team#128

@codecov-staging
Copy link

Codecov Report

Patch coverage is 66.66% of modified lines.

Files Changed Coverage
services/report.py 66.66%

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #81 (12b7a58) into main (d576544) will increase coverage by 0.04%.
The diff coverage is 66.66%.

❗ Current head 12b7a58 differs from pull request most recent head 67313db. Consider uploading reports for the commit 67313db to get more accurate results

@@           Coverage Diff           @@
##            main     #81     +/-   ##
=======================================
+ Coverage   95.25   95.29   +0.04     
=======================================
  Files        695     694      -1     
  Lines      14769   14748     -21     
=======================================
- Hits       14068   14053     -15     
+ Misses       701     695      -6     
Flag Coverage Δ
unit ?
unit-latest-uploader ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
services/report.py 92.30% <66.66%> (-2.94%) ⬇️

... and 5 files with indirect coverage changes

@scott-codecov scott-codecov merged commit 3b0f475 into main Aug 16, 2023
8 checks passed
@scott-codecov scott-codecov deleted the scott/report-file-not-in-storage branch August 16, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileNotInStorageError error on v2 api endpoint
2 participants