ref: Add agreement in user and sync updates with owner agreement (#390) #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JerrySentry
changed the title
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
Codecov Report
@@ Coverage Diff @@
## main #98 +/- ##
=====================================
Coverage 95.27 95.27
=====================================
Files 696 697 +1
Lines 14807 14822 +15
=====================================
+ Hits 14106 14121 +15
Misses 701 701
Flags with carried forward coverage won't be shown. Click here to find out more.
|
JerrySentry
changed the title
codecov_auth/commands/owner/interactors/save_terms_agreement.py
Outdated
Show resolved
Hide resolved
JerrySentry
commented
Aug 30, 2023
adrian-codecov
approved these changes
Aug 30, 2023
| owner_profile.save() | ||
|
|
||
| # Store agreements in user table as well | ||
| user = User.objects.get(id=self.current_owner.user_id) |
There was a problem hiding this comment.
@JerrySentry This record should already be available at self.current_user. It's set here:
codecov-api/codecov/commands/base.py
Line 34 in 958cfcf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/Motivation
What is the feature? Why is this being done?
This is for auth refactor, add signed agreements flag to user table for users signed in via a non-git provider (ie not row in owners table).
Part 1 of 3 releases for this overall task.
Adds new columns and updates user.agreements when owner.agreements is updated.
Links to relevant tickets
codecov/engineering-team#390