Th/feat/use wrapper #193
Merged
Th/feat/use wrapper #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #193 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 4 4
=========================================
Hits 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
drazisil-codecov
requested changes
Apr 12, 2024
| filters: *filters | ||
| requires: [test-linux, test-macos, test-windows] | ||
|
|
||
| - orb-tools/publish: | ||
| enable-pr-comment: false | ||
| enable_pr_comment: false |
There was a problem hiding this comment.
Are these supposed to be underscored?
There was a problem hiding this comment.
@drazisil-codecov yes to all of these, it was a change from orb-tools@v11 to orb-tools@v12 docs
There was a problem hiding this comment.
Also CircleCI-Public/orb-tools-orb#181
Parameter Standardizations
Snake Case (to match CircleCI's native parameter styles)
Consistent Env Var Naming
drazisil-codecov
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/codecov/infrastructure-team/issues/258