Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use sys.exit() instead of just exit() #371

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

joseph-sentry
Copy link
Contributor

related to: #370

Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7c5d874) 96.01% compared to head (2fc9d87) 96.01%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #371   +/-   ##
=======================================
  Coverage   96.01%   96.01%           
=======================================
  Files          81       81           
  Lines        2813     2814    +1     
=======================================
+ Hits         2701     2702    +1     
  Misses        112      112           
Flag Coverage Δ
python3.10 96.30% <100.00%> (+<0.01%) ⬆️
python3.11 96.30% <100.00%> (+<0.01%) ⬆️
python3.8 96.27% <100.00%> (+<0.01%) ⬆️
python3.9 96.27% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joseph-sentry joseph-sentry marked this pull request as ready for review February 2, 2024 15:27
Copy link
Contributor

@giovanni-guidini giovanni-guidini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how this helps with the problem, but OK

Next time if you could include an example of why this solves the issue it would be positive for the reader

@joseph-sentry
Copy link
Contributor Author

since the error message in the original ticket mentions the exit command not being defined I'm assuming it's because we're using the exit function not in sys which apparently is meant only for use in the python REPL and shouldn't be used in programs, in the case that site is not loaded (see: https://docs.python.org/3/library/constants.html#constants-added-by-the-site-module)

@joseph-sentry joseph-sentry merged commit da50de0 into main Feb 2, 2024
17 of 18 checks passed
@joseph-sentry joseph-sentry deleted the joseph/use-sys-exit branch February 2, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants