Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Normalize asset file names #27

Merged
merged 12 commits into from
Dec 19, 2023
Merged

feat: Normalize asset file names #27

merged 12 commits into from
Dec 19, 2023

Conversation

nicholas-codecov
Copy link
Collaborator

Description

This PR adds in the functionality to replace asset file hashes with a wildcard symbol.

Notable Changes

  • Turn on dryRun option for all examples
  • Add in normalizePath function to normalize asset filenames
  • Configure bundler plugins to use normalizePath function

@codecov Codecov
Copy link

codecov bot commented Dec 14, 2023 •
edited

Codecov Report

Attention: 41 lines in your changes are missing coverage. Please review.

Comparison is base (78966dc) 84.56% compared to head (d786df2) 83.52%.

Files Patch % Lines
...ack-bundle-analysis/webpackBundleAnalysisPlugin.ts 5.55% 17 Missing ⚠️
...llup-bundle-analysis/rollupBundleAnalysisPlugin.ts 0.00% 10 Missing and 2 partials ⚠️
...c/vite-bundle-analysis/viteBundleAnalysisPlugin.ts 0.00% 10 Missing and 2 partials ⚠️
Additional details and impacted files
Components Coverage Δ
Plugin core 96.33% <100.00%> (+0.07%) ⬆️
Rollup plugin 7.35% <0.00%> (-0.59%) ⬇️
Vite plugin 7.35% <0.00%> (-0.59%) ⬇️
Webpack plugin 33.33% <60.46%> (+23.52%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AbhiPrasad
AbhiPrasad approved these changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

packages/bundler-plugin-core/src/utils/__tests__/normalizePath.test.ts Outdated Show resolved Hide resolved
@nicholas-codecov
some more progress towards getting webpack playing nicely
07933a1
@nicholas-codecov
swap lib from ES2020 to ES2021
30527c5
@nicholas-codecov
use includes instead of a direct comparison
bd55c79
@nicholas-codecov
create a function for webpack to determine the file format string
d2c2bd8
@nicholas-codecov
use new findFileFormat function to determine the format string being …
beabf84 
…used
@nicholas-codecov
update the rollup plugin to use asset format for assets and chunk for…
3db796b 
…mat for chunks
@nicholas-codecov
update the vite plugin to use asset format for assets and chunk forma…
6c0ba92 
…t for chunks
@nicholas-codecov
clean up the normalizePath function into it's more finalized version
430aca9
@nicholas-codecov
turn on dry run for all examples for testing purposes
8a07e1d
@nicholas-codecov
refactor of the normalizePath function to escape regex and handle mul…
a7ba013 
…tiple hashes in format string
@nicholas-codecov
update normalizePath tests to follow a table test format
234ae4d
@nicholas-codecov nicholas-codecov merged commit 6a0ba97 into main Dec 19, 2023
8 of 12 checks passed
@nicholas-codecov nicholas-codecov deleted the some-work-on-normalizing branch December 19, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nicholas-codecov @AbhiPrasad