Pipe #30
Pipe #30
Conversation
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
==========================================
+ Coverage 95.59% 96.13% +0.54%
==========================================
Files 17 16 -1
Lines 227 233 +6
Branches 43 44 +1
==========================================
+ Hits 217 224 +7
+ Misses 10 9 -1
Continue to review full report at Codecov.
|
|
@stevepeak For some reason the test goes stale after passing all tests. Not sure what is going on yet. |
|
@stevepeak finally it passes. But codecov doesn't seem to pick it up? |
…he readable event
| var timer = setTimeout(function() { | ||
| if (!readingPiped) { | ||
| codecov.upload(args); | ||
| process.exit(); |
There was a problem hiding this comment.
I think this may be exiting before uploading is complete.
|
The process seems to quite before uploading is started. You can see this in the build logs. I think the issue is beacuse of the pipe timeout/exit. |
|
Closing due to inactivity |
|
I'll revisit this in January. |
|
It would be just fine without the timeout IMO. Most CI services are getting slow depending on global usage. A timeout will only make the report fails inconsistently. Let me know if you don't have time to work on this I could try to take over. |
|
@hadrienk thanks for taking over. I just don't have time ATM |
|
@hadrienk I vaguely remember having the timeout to distinguish between piped input and file input but I don't remember if I actually tested this or if it's the remnants of an issue with a different project I wrote, that has the same listening implementation. |
|
So I just need to remove the timeout? I should be able to find time for that soon. |
|
Thanks! I will test it tomorrow.
…On Tue, Mar 13, 2018, 21:28 Jon Ege Ronnenberg ***@***.***> wrote:
@hadrienk <https://github.com/hadrienk> Checkout #92
<#92>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#30 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAMp8RCUJNcAAj3gUwuWVO_h2xGa6K18ks5teCvtgaJpZM4J1zTi>
.
|
This is my initial PR for reading piped reports - #29 . It needs a little more work and I would like to hear your opinion.
3 questions:
if (files) ...will always be true. Why not remove it?What is the difference between lcov and coverage.json, except the data format? E.g. when is one generated over the other and is it by- just saw your answer in comment-244543227codecov-nodeor an 3th party?