Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

codecov stopped adding GitHub PR comments #205

Closed
vangent opened this issue Jun 24, 2019 · 5 comments
Closed

codecov stopped adding GitHub PR comments #205

vangent opened this issue Jun 24, 2019 · 5 comments
Assignees

Comments

@vangent
Copy link

vangent commented Jun 24, 2019

My team repo (https://github.com/google/go-cloud) has the Codedov GitHub app installed, and a codecov .yaml file. Comments used to work fine (example), but about 2 weeks ago they stopped (example PR with passing tests but no comment).

The upload to codecov appears to work fine; there are no errors, and the URL in the output goes to a page that looks correct. Example:

  _____          _
 / ____|        | |
| |     ___   __| | ___  ___ _____   __
| |    / _ \ / _` |/ _ \/ __/ _ \ \ / /
| |___| (_) | (_| |  __/ (_| (_) \ V /
 \_____\___/ \__,_|\___|\___\___/ \_/
                              Bash-8a28df4
==> Travis CI detected.
    project root: .
    Fixing merge commit SHA
    Yaml found at: .codecov.yml
==> Running gcov in . (disable via -X gcov)
==> Python coveragepy not found
==> Searching for coverage reports in:
    + .
    -> Found 1 reports
==> Detecting git/mercurial file structure
==> Appending build variables
    + TRAVIS_OS_NAME
    + _TRAVIS_RESOLVED_GIMME_GO_VERSION_INT
==> Reading reports
    + ./coverage.out bytes=15268975
==> Appending adjustments
    http://docs.codecov.io/docs/fixing-reports
    + Found adjustments
==> Gzipping contents
==> Uploading reports
    url: https://codecov.io
    query: branch=master&commit=ae2ed6be523c1855b1f2a2e12a43ab392b4754de&build=6599.1&build_url=&name=&tag=&slug=google%2Fgo-cloud&service=travis&flags=&pr=2398&job=210598986
    -> Pinging Codecov
https://codecov.io/upload/v4?package=bash-8a28df4&token=&branch=master&commit=ae2ed6be523c1855b1f2a2e12a43ab392b4754de&build=6599.1&build_url=&name=&tag=&slug=google%2Fgo-cloud&service=travis&flags=&pr=2398&job=210598986
    -> Uploading
    -> View reports at https://codecov.io/github/google/go-cloud/commit/ae2ed6be523c1855b1f2a2e12a43ab392b4754de

(and the URL at the bottom of that snippet looks fine).

Any suggestions on what could be going wrong?

@subhashb
Copy link

Same problem observed in http://github.com/proteanhq/protean/ repo.
The commit that triggered this error was an upgrade of pytest from version 4.6.1 to 4.6.2.

$ codecov
      _____          _
     / ____|        | |
    | |     ___   __| | ___  ___ _____   __
    | |    / _ \ / _  |/ _ \/ __/ _ \ \ / /
    | |___| (_) | (_| |  __/ (_| (_) \ V /
     \_____\___/ \____|\___|\___\___/ \_/
                                    v2.0.15
==> Detecting CI provider
    Travis Detected
    Fixing merge commit SHA
==> Preparing upload
==> Processing gcov (disable by -X gcov)
    Executing gcov (find /home/travis/build/proteanhq/protean -not -path './bower_components/**' -not -path './node_modules/**' -not -path './vendor/**' -type f -name '*.gcno'  -exec gcov -pb  {} +)
==> Collecting reports
    Generating coverage xml reports for Python
    + /home/travis/build/proteanhq/protean/coverage.xml bytes=141032
==> Appending environment variables
    + TRAVIS_OS_NAME
    + TRAVIS_PYTHON_VERSION
==> Uploading
    .url https://codecov.io
    .query commit=c19e94d5b5da1379d1531c5f7eb72f8f7173b33b&branch=master&job=551005641&pr=187&service=travis&build=629.1&slug=proteanhq%2Fprotean&package=py2.0.15
    Pinging Codecov...
    Uploading to S3...
    https://codecov.io/github/proteanhq/protean/commit/c19e94d5b5da1379d1531c5f7eb72f8f7173b33b

@vangent
Copy link
Author

vangent commented Jul 4, 2019

Our PRs are getting the comments again, apparently randomly.

@thomasrockhu
Copy link
Contributor

Hi @vangent, just letting you know that this has been brought up to the product team.

@thomasrockhu thomasrockhu self-assigned this Jul 4, 2019
@mlewand
Copy link

mlewand commented Apr 7, 2020

@thomasrockhu Any updates on that? I also noticed that codecov reports sometimes are not posted to the PR, despite being uploaded successfully and properly appearing on codecov website.

This is one of the top google results that you hit when looking for this issue, so that's why I'm posting here.

@thomasrockhu
Copy link
Contributor

thomasrockhu commented May 22, 2020

@mlewand and @ryanprater, this has been fixed for the original poster. Because a solution can vary for repositories, I'm going to close this out. But if you would like to me take a look at your issue, please make a post in our community boards.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants