Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

open simplecov requirement to 0.21.x #125

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

klausbadelt
Copy link
Contributor

This PR allows the latest version of simplecov. 0.21.x was explicitly excluded, but I see no issues and tests pass. Please let me know if I'm missing anything.

@codecov
Copy link

codecov bot commented Jan 9, 2021

Codecov Report

Merging #125 (f360765) into master (04bcb6f) will increase coverage by 1.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
+ Coverage   90.52%   91.76%   +1.23%     
==========================================
  Files           1        1              
  Lines         359      340      -19     
==========================================
- Hits          325      312      -13     
+ Misses         34       28       -6     
Impacted Files Coverage Δ
lib/codecov.rb 91.76% <0.00%> (+1.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04bcb6f...f360765. Read the comment docs.

@klausbadelt
Copy link
Contributor Author

I missed the discussion in #116. Still, tests don't fail with simplecov 0.21.2. If your parser would fail now, I suggest we need tests here to reflect the requirement.

@thomasrockhu thomasrockhu merged commit 5cc46b0 into codecov:master Jan 14, 2021
@jerrode
Copy link

jerrode commented Jan 15, 2021

Thanks @klausbadelt! Excited to have you using Codecov.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants