Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Failed tests PR comment display by grouping by suite and removing tables #1524

Open
Tracked by #1525
Adal3n3 opened this issue Apr 8, 2024 · 2 comments
Open
Tracked by #1525
Assignees
Labels
Dev-Ready This means the UX is reviewed and ready for prioritization scheduling.

Comments

@Adal3n3
Copy link

Adal3n3 commented Apr 8, 2024

Problem to solve

We found that using a two-column table to display all the failed tests resulted in unreadable failure messages. A suggested solution is to remove the table and instead group the tests by test suite.

Example: dcramer/peated#153

Screenshot_20240408-105635

Possible solution

Propose a new design as suggested above.

Additional Information

@Adal3n3 Adal3n3 added the in discovery The design, product, and specifications require refinement label Apr 8, 2024
@rohan-at-sentry rohan-at-sentry changed the title Improve Failed tests PR comment display Improve Failed tests PR comment display by grouping by suite and removing tables Apr 8, 2024
@Adal3n3
Copy link
Author

Adal3n3 commented Apr 10, 2024

@rohan-at-sentry @joseph-sentry
Design update: Figma link

Screenshot 2024-04-10 at 11 10 54 AM

@rohan-at-sentry
Copy link

should be able to parse out test name - #1551

@Adal3n3 Adal3n3 added Dev-Ready This means the UX is reviewed and ready for prioritization scheduling. and removed in discovery The design, product, and specifications require refinement labels Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev-Ready This means the UX is reviewed and ready for prioritization scheduling.
Projects
None yet
Development

No branches or pull requests

3 participants