Updated README to note Cobertura and JDK11 restriction #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to use Cobertura with Travis, you must specify an earlier version of the JDK. Cobertura will not work with travis out of the box as Travis uses JDK 11 (currently). The build will fail with: ``` [ERROR] Failed to execute goal org.codehaus.mojo:cobertura-maven-plugin:2.7:instrument (default-cli) on project xbdd-maven-plugin: Execution default-cli of goal org.codehaus.mojo:cobertura-maven-plugin:2.7:instrument failed: Plugin org.codehaus.mojo:cobertura-maven-plugin:2.7 or one of its dependencies could not be resolved: Could not find artifact com.sun:tools:jar:0 at specified path /usr/local/lib/jvm/openjdk11/../lib/tools.jar -> [Help 1] ```
|
48 hours spent on getting CodeCov to work with Cobertura. I wish I had seen your Pull Request earlier. I tried JaCoCo as well. It seems that even JaCoCo doesn't support the latest JDK. Thanks a lot! I can sleep now! |
|
Should be merged definetly. |
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
=======================================
Coverage 50.00% 50.00%
=======================================
Files 1 1
Lines 4 4
Branches 1 1
=======================================
Hits 2 2
Misses 1 1
Partials 1 1 Continue to review full report at Codecov.
|
thomasrockhu
approved these changes
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to use Cobertura with Travis, you must specify an earlier version of the JDK. Cobertura will not work with travis out of the box as Travis uses JDK 11 (currently). The build will fail with: