move fragment schema next to gql fragment string

codecov · May 10, 2024 · 5b09479 · 5b09479
1 parent 7fd328c
commit 5b09479
Show file tree

Hide file tree

Showing 2 changed files with 56 additions and 54 deletions.
diff --git a/src/services/pull/fragments.js b/src/services/pull/fragments.js
@@ -1,3 +1,5 @@
+import { z } from 'zod'
+
 export const HeaderOnPullFragment = `
 fragment HeaderOnPullFragment on Pull {
   pullId
@@ -253,6 +255,59 @@ fragment FileComparisonWithBase on Pull {
   }
 }`
 
+const CoverageLineSchema = z.enum(['H', 'M', 'P'])
+
+export const ComparisonSchema = z.object({
+  __typename: z.literal('Comparison'),
+  impactedFile: z
+    .object({
+      headName: z.string().nullable(),
+      hashedPath: z.string(),
+      isNewFile: z.boolean(),
+      isRenamedFile: z.boolean(),
+      isDeletedFile: z.boolean(),
+      isCriticalFile: z.boolean(),
+      changeCoverage: z.number().nullable(),
+      baseCoverage: z
+        .object({
+          percentCovered: z.number().nullable(),
+        })
+        .nullable(),
+      headCoverage: z
+        .object({
+          percentCovered: z.number().nullable(),
+        })
+        .nullable(),
+      patchCoverage: z
+        .object({
+          percentCovered: z.number().nullable(),
+        })
+        .nullable(),
+      segments: z.object({
+        results: z.array(
+          z.object({
+            header: z.string(),
+            hasUnintendedChanges: z.boolean(),
+            lines: z.array(
+              z.object({
+                baseNumber: z.string().nullable(),
+                headNumber: z.string().nullable(),
+                baseCoverage: CoverageLineSchema.nullable(),
+                headCoverage: CoverageLineSchema.nullable(),
+                content: z.string().nullable(),
+                coverageInfo: z.object({
+                  hitCount: z.number().nullable(),
+                  hitUploadIds: z.array(z.number()).nullable(),
+                }),
+              })
+            ),
+          })
+        ),
+      }),
+    })
+    .nullable(),
+})
+
 export const PullCompareWithBaseFragment = `
 fragment PullCompareWithBaseFragment on Pull {
   compareWithBase {

diff --git a/src/services/pull/usePrefetchSingleFileComp.tsx b/src/services/pull/usePrefetchSingleFileComp.tsx
@@ -17,62 +17,9 @@ import Api from 'shared/api'
 import { NetworkErrorObject } from 'shared/api/helpers'
 import A from 'ui/A'
 
-import { FileComparisonWithBase } from './fragments'
+import { ComparisonSchema, FileComparisonWithBase } from './fragments'
 import { transformImpactedFileData } from './utils'
 
-const CoverageLineSchema = z.enum(['H', 'M', 'P'])
-
-const ComparisonSchema = z.object({
-  __typename: z.literal('Comparison'),
-  impactedFile: z
-    .object({
-      headName: z.string().nullable(),
-      hashedPath: z.string(),
-      isNewFile: z.boolean(),
-      isRenamedFile: z.boolean(),
-      isDeletedFile: z.boolean(),
-      isCriticalFile: z.boolean(),
-      changeCoverage: z.number().nullable(),
-      baseCoverage: z
-        .object({
-          percentCovered: z.number().nullable(),
-        })
-        .nullable(),
-      headCoverage: z
-        .object({
-          percentCovered: z.number().nullable(),
-        })
-        .nullable(),
-      patchCoverage: z
-        .object({
-          percentCovered: z.number().nullable(),
-        })
-        .nullable(),
-      segments: z.object({
-        results: z.array(
-          z.object({
-            header: z.string(),
-            hasUnintendedChanges: z.boolean(),
-            lines: z.array(
-              z.object({
-                baseNumber: z.string().nullable(),
-                headNumber: z.string().nullable(),
-                baseCoverage: CoverageLineSchema.nullable(),
-                headCoverage: CoverageLineSchema.nullable(),
-                content: z.string().nullable(),
-                coverageInfo: z.object({
-                  hitCount: z.number().nullable(),
-                  hitUploadIds: z.array(z.number()).nullable(),
-                }),
-              })
-            ),
-          })
-        ),
-      }),
-    })
-    .nullable(),
-})
-
 const FileComparisonWithBaseSchema = z.object({
   compareWithBase: z
     .discriminatedUnion('__typename', [