ref: Quick Refactor to Parse the Whole Response of Converted Hooks #2208
Conversation
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## main #2208 +/- ##
=======================================
Coverage 97.94% 97.94%
=======================================
Files 698 698
Lines 7926 7929 +3
Branches 1887 1892 +5
=======================================
+ Hits 7763 7766 +3
Misses 161 161
Partials 2 2 Continue to review full report in Codecov by Sentry.
|
Codecov Report
@@ Coverage Diff @@
## main #2208 +/- ##
=====================================
Coverage 97.94 97.94
=====================================
Files 698 698
Lines 7926 7929 +3
Branches 1887 1892 +5
=====================================
+ Hits 7763 7766 +3
Misses 161 161
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
| @@ -132,7 +138,7 @@ export const useCommitHeaderData = ({ | |||
| } | |||
|
|
|||
| return { | |||
| commit: data?.repository?.commit, | |||
| commit: data?.owner?.repository?.commit ?? null, | |||
There was a problem hiding this comment.
so just so i understand this better, we can't return undefined here?
There was a problem hiding this comment.
It's because of the way that GraphQL works. If you request a field it will either return the value or null it will never return undefined so we don't wan't the TS value to reflect something it could never be. Which if we set to undefined here it won't pass the type validation that zod runs and will error out.
| ]) | ||
| .nullable(), | ||
| }) | ||
| .nullable(), |
There was a problem hiding this comment.
do we plan to take out the queries to their own files?
There was a problem hiding this comment.
I don't see any benefit as to removing the queries as when they're only used in a single location. I also think it's somewhat of a bad practice in these instances to move a string to it's own file.
nicholas-codecov
deleted the
gh-eng-355-quick-refactor-to-parse-the-whole-response
branch
…2208) Quick refactor to parse the whole response over just smaller portions.
Description
This quick refactor updates hooks that have already been converted over to use the new
repositoryfield to slightly adjust the return value as well as parse the whole response rather then a small portion.Notable Changes
useCommitHeaderDatauseCommitPageDatausePullHeadDatausePullPageData