Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove tokenless prompt #2214

Merged
merged 3 commits into from
Sep 7, 2023
Merged

Conversation

thomasrockhu-codecov
Copy link
Contributor

Description

Although tokenless uploading is supported, due to GitHub rate limit issues, we cannot always guarantee that we can call the GitHub API requesting verification of an upload.

Code Example

N/A

Notable Changes

N/A

Screenshots

Halp

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@netlify
Copy link

netlify bot commented Aug 18, 2023

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit cc7c748
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/64fa22b7912d700008ab5155
😎 Deploy Preview https://deploy-preview-2214--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #2214 (cc7c748) into main (4eae345) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2214   +/-   ##
=====================================
  Coverage   97.94   97.94           
=====================================
  Files        698     698           
  Lines       7931    7931           
  Branches    1886    1886           
=====================================
  Hits        7768    7768           
  Misses       161     161           
  Partials       2       2           
Files Changed Coverage Δ
...s/tabs/OrgUploadToken/RegenerateOrgUploadToken.jsx 100.00% <ø> (ø)
...eralTab/Tokens/RepoUploadToken/RepoUploadToken.jsx 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eae345...cc7c748. Read the comment docs.

📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@codecov-staging
Copy link

codecov-staging bot commented Sep 7, 2023

Codecov Report

Merging #2214 (cc7c748) into main (4eae345) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2214   +/-   ##
=======================================
  Coverage   97.94%   97.94%           
=======================================
  Files         698      698           
  Lines        7931     7931           
  Branches     1886     1886           
=======================================
  Hits         7768     7768           
  Misses        161      161           
  Partials        2        2           
Files Changed Coverage
...s/tabs/OrgUploadToken/RegenerateOrgUploadToken.jsx ø
...eralTab/Tokens/RepoUploadToken/RepoUploadToken.jsx ø

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eae345...cc7c748. Read the comment docs.

📢 Thoughts on this report? Let us know!.

@thomasrockhu-codecov thomasrockhu-codecov merged commit 3de912a into main Sep 7, 2023
15 checks passed
@thomasrockhu-codecov thomasrockhu-codecov deleted the remove-tokenless-prompt branch September 7, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants