ref: Update "team bot missing" for users that have GitHub app to "Issue with Github app" #2249
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2249 +/- ##
=======================================
+ Coverage 97.94 97.95 +0.01
=======================================
Files 698 698
Lines 7925 7932 +7
Branches 1888 1886 -2
=======================================
+ Hits 7762 7769 +7
Misses 161 161
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## main #2249 +/- ##
=======================================
Coverage 97.94% 97.94%
=======================================
Files 698 698
Lines 7925 7932 +7
Branches 1888 1886 -2
=======================================
+ Hits 7762 7769 +7
Misses 161 161
Partials 2 2
Continue to review full report in Codecov by Sentry.
📢 Thoughts on this report? Let us know!. |
RulaKhaled
force-pushed
the
missing-bot
branch
from
491c13e
to
89a196c
Compare
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| <div className="gap-1 lg:flex lg:w-max"> | ||
| <span> | ||
| The bot posts the coverage report comment on pull requests. If | ||
| you're using GitHub, the best way to integrate with Codecov.io is | ||
| to Install | ||
| </span> | ||
| <A to={{ pageName: 'codecovGithubApp' }}> Codecov's GitHub App.</A> | ||
| </div> |
There was a problem hiding this comment.
Wanna switch this to a <p> 👀
There was a problem hiding this comment.
Also just noticed the lg:w-max, that is not a valid tailwind class the w-max specifically. See here.
There was a problem hiding this comment.
nice catch, i think we can safely get rid of all classes in this div
Description
Add one more case to missing bot banner to handle users with github app but missing bot.
issue: codecov/engineering-team#276
Screenshots
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.