Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Branch dropdown search merged + unmerged branches #2251

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

scott-codecov
Copy link
Contributor

@scott-codecov scott-codecov commented Sep 7, 2023

The API returns only unmerged branches by default which is nice in that it keeps the branch selector fairly tidy and relevant to current work. When we're searching for a specific branch we'd like to search across merged branches as well. This passes the necessary GraphQL resolver filter in that case.

From codecov/codecov-api#96

@netlify
Copy link

netlify bot commented Sep 7, 2023

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 00abff3
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/64fa2f41c7904d000857f9f9
😎 Deploy Preview https://deploy-preview-2251--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-staging
Copy link

Codecov Report

Merging #2251 (00abff3) into main (3de912a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2251   +/-   ##
=======================================
  Coverage   97.94%   97.94%           
=======================================
  Files         698      698           
  Lines        7931     7936    +5     
  Branches     1886     1890    +4     
=======================================
+ Hits         7768     7773    +5     
  Misses        161      161           
  Partials        2        2           
Files Changed Coverage
src/services/branches/useBranches.js 100.00%

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3de912a...00abff3. Read the comment docs.

📢 Thoughts on this report? Let us know!.

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #2251 (00abff3) into main (3de912a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2251     +/-   ##
=======================================
+ Coverage   97.94   97.95   +0.01     
=======================================
  Files        698     698             
  Lines       7931    7936      +5     
  Branches    1886    1890      +4     
=======================================
+ Hits        7768    7773      +5     
  Misses       161     161             
  Partials       2       2             
Files Changed Coverage Δ
src/services/branches/useBranches.js 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3de912a...00abff3. Read the comment docs.

📢 Have feedback on the report? Share it here.

@scott-codecov scott-codecov merged commit e77ee96 into main Sep 8, 2023
17 checks passed
@scott-codecov scott-codecov deleted the scott/search-all-branches branch September 8, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants