Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Remove Trial Flag from Actions Billing #2255

Merged

Conversation

nicholas-codecov
Copy link
Contributor

Description

Another day another PR removing the trial flag, this time from the ActionsBilling component. I thought I'd also update the test setup function to take a object argument so that if we need to add another flag in it's not a positional argument which isn't fun to clean up.

Notable Changes

  • Remove flag from ActionsBilling component
  • Update tests, including swapping to obj arg for setup

@netlify
Copy link

netlify bot commented Sep 11, 2023

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit f04fc47
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/64ff62c7c69e6e0008e1880d
😎 Deploy Preview https://deploy-preview-2255--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-staging
Copy link

Codecov Report

Merging #2255 (f04fc47) into main (a404179) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2255      +/-   ##
==========================================
- Coverage   97.94%   97.94%   -0.01%     
==========================================
  Files         698      698              
  Lines        7948     7947       -1     
  Branches     1893     1893              
==========================================
- Hits         7785     7784       -1     
  Misses        161      161              
  Partials        2        2              
Files Changed Coverage
...tPlanCard/shared/ActionsBilling/ActionsBilling.jsx ø

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a404179...f04fc47. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #2255 (f04fc47) into main (a404179) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2255   +/-   ##
=====================================
  Coverage   97.95   97.95           
=====================================
  Files        698     698           
  Lines       7948    7947    -1     
  Branches    1893    1893           
=====================================
- Hits        7785    7784    -1     
  Misses       161     161           
  Partials       2       2           
Files Changed Coverage Δ
...tPlanCard/shared/ActionsBilling/ActionsBilling.jsx 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a404179...f04fc47. Read the comment docs.

@nicholas-codecov nicholas-codecov merged commit 60967dc into main Sep 12, 2023
17 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-314-ref-remove-trial-flag-from-actions-billing branch September 12, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants