Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Quick Coverage Tab Flag Multi Select Follows #2275

Merged
merged 10 commits into from
Sep 26, 2023

Conversation

nicholas-codecov
Copy link
Contributor

@nicholas-codecov nicholas-codecov commented Sep 20, 2023

Description

Just some quick change to make the QoL of the coverage tab multi select a bit better, focused around updating the error message when a flag is selected and no results are returned, and carrying along the query params when a user navigates down/up a directory or in/out of a file.

Closes codecov/engineering-team#220

Notable Changes

  • Added in new queryParam option to treeView and fileViewer in useNavLinks
  • Pull out query params in useTreePaths and pass along accordingly
  • Update DirEntry and FileEntry components to accept queryParams prop
  • Pull out query params in BranchDirEntry and BranchFileEntry and pass along

@netlify
Copy link

netlify bot commented Sep 20, 2023

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 8ab8650
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/6512acfeee296100083ed937
😎 Deploy Preview https://deploy-preview-2275--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #2275 (8ab8650) into main (d1439ba) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2275   +/-   ##
=====================================
  Coverage   98.04   98.04           
=====================================
  Files        703     703           
  Lines       8145    8159   +14     
  Branches    1955    1967   +12     
=====================================
+ Hits        7985    7999   +14     
  Misses       158     158           
  Partials       2       2           
Files Coverage Δ
...ubroute/FileExplorer/shared/RepoContentsResult.jsx 100.00% <ø> (ø)
src/services/navigation/useNavLinks/useNavLinks.js 100.00% <100.00%> (ø)
...ontentsTable/TableEntries/BaseEntries/DirEntry.jsx 100.00% <100.00%> (ø)
...ntentsTable/TableEntries/BaseEntries/FileEntry.jsx 94.73% <100.00%> (+0.29%) ⬆️
...able/TableEntries/BranchEntries/BranchDirEntry.jsx 100.00% <100.00%> (ø)
...ble/TableEntries/BranchEntries/BranchFileEntry.jsx 100.00% <100.00%> (ø)
src/shared/treePaths/useTreePaths.js 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1439ba...8ab8650. Read the comment docs.

@codecov-public-qa
Copy link

codecov-public-qa bot commented Sep 20, 2023

Codecov Report

Merging #2275 (8ab8650) into main (d1439ba) will increase coverage by 0.07%.
The diff coverage is 84.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2275      +/-   ##
==========================================
+ Coverage   34.50%   34.58%   +0.07%     
==========================================
  Files         655      655              
  Lines        8001     8015      +14     
  Branches     1915     1920       +5     
==========================================
+ Hits         2761     2772      +11     
- Misses       5217     5220       +3     
  Partials       23       23              
Files Changed Coverage Δ
...ubroute/FileExplorer/shared/RepoContentsResult.jsx 0.00% <ø> (ø)
...ontentsTable/TableEntries/BaseEntries/DirEntry.jsx 14.28% <0.00%> (-2.39%) ⬇️
...ntentsTable/TableEntries/BaseEntries/FileEntry.jsx 15.78% <0.00%> (-0.88%) ⬇️
...able/TableEntries/BranchEntries/BranchDirEntry.jsx 20.00% <0.00%> (-5.00%) ⬇️
...ble/TableEntries/BranchEntries/BranchFileEntry.jsx 16.66% <0.00%> (-3.34%) ⬇️
src/services/navigation/useNavLinks/useNavLinks.js 88.73% <100.00%> (+0.49%) ⬆️
src/shared/treePaths/useTreePaths.js 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1439ba...8ab8650. Read the comment docs.

Copy link
Contributor

@RulaKhaled RulaKhaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good, left a comment

src/services/navigation/useNavLinks/useNavLinks.js Outdated Show resolved Hide resolved
src/services/navigation/useNavLinks/useNavLinks.js Outdated Show resolved Hide resolved
@codecov-staging
Copy link

codecov-staging bot commented Sep 25, 2023

Codecov Report

Merging #2275 (8ab8650) into main (d1439ba) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2275   +/-   ##
=======================================
  Coverage   98.03%   98.03%           
=======================================
  Files         703      703           
  Lines        8145     8159   +14     
  Branches     1917     1920    +3     
=======================================
+ Hits         7985     7999   +14     
  Misses        158      158           
  Partials        2        2           
Files Coverage Δ
...ubroute/FileExplorer/shared/RepoContentsResult.jsx 100.00% <ø> (ø)
src/services/navigation/useNavLinks/useNavLinks.js 100.00% <100.00%> (ø)
...ontentsTable/TableEntries/BaseEntries/DirEntry.jsx 100.00% <100.00%> (ø)
...ntentsTable/TableEntries/BaseEntries/FileEntry.jsx 94.73% <100.00%> (+0.29%) ⬆️
...able/TableEntries/BranchEntries/BranchDirEntry.jsx 100.00% <100.00%> (ø)
...ble/TableEntries/BranchEntries/BranchFileEntry.jsx 100.00% <100.00%> (ø)
src/shared/treePaths/useTreePaths.js 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1439ba...8ab8650. Read the comment docs.

@nicholas-codecov nicholas-codecov merged commit 587432e into main Sep 26, 2023
31 checks passed
@nicholas-codecov nicholas-codecov deleted the fix-quick-flag-multi-select-follows branch September 26, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Flag Based Coverage View in Coverage Tab
2 participants