-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Quick Coverage Tab Flag Multi Select Follows #2275
Conversation
…am and pass to base components
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## main #2275 +/- ##
=====================================
Coverage 98.04 98.04
=====================================
Files 703 703
Lines 8145 8159 +14
Branches 1955 1967 +12
=====================================
+ Hits 7985 7999 +14
Misses 158 158
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov Report
@@ Coverage Diff @@
## main #2275 +/- ##
==========================================
+ Coverage 34.50% 34.58% +0.07%
==========================================
Files 655 655
Lines 8001 8015 +14
Branches 1915 1920 +5
==========================================
+ Hits 2761 2772 +11
- Misses 5217 5220 +3
Partials 23 23
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks good, left a comment
…to single object/arg
…to single object/arg
Codecov Report
@@ Coverage Diff @@
## main #2275 +/- ##
=======================================
Coverage 98.03% 98.03%
=======================================
Files 703 703
Lines 8145 8159 +14
Branches 1917 1920 +3
=======================================
+ Hits 7985 7999 +14
Misses 158 158
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Description
Just some quick change to make the QoL of the coverage tab multi select a bit better, focused around updating the error message when a flag is selected and no results are returned, and carrying along the query params when a user navigates down/up a directory or in/out of a file.
Closes codecov/engineering-team#220
Notable Changes
queryParam
option totreeView
andfileViewer
inuseNavLinks
useTreePaths
and pass along accordinglyDirEntry
andFileEntry
components to acceptqueryParams
propBranchDirEntry
andBranchFileEntry
and pass along