Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Default to file explorer for the first time UX #2289

Merged
merged 3 commits into from
Sep 27, 2023

Conversation

RulaKhaled
Copy link
Contributor

@RulaKhaled RulaKhaled commented Sep 26, 2023

Description

if first pull request, default to file explorer.

Changes

  • Update pulls page to default to file explorer for the first pull request
  • Tests

issue: codecov/engineering-team#404

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-staging
Copy link

codecov-staging bot commented Sep 26, 2023

Codecov Report

Merging #2289 (ec8100f) into main (d1e1888) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2289   +/-   ##
=======================================
  Coverage   98.03%   98.03%           
=======================================
  Files         703      703           
  Lines        8151     8154    +3     
  Branches     1965     1923   -42     
=======================================
+ Hits         7991     7994    +3     
  Misses        158      158           
  Partials        2        2           
Files Coverage Δ
...PullRequestPageContent/ErrorBanner/ErrorBanner.jsx 100.00% <ø> (ø)
.../PullRequestPageContent/PullRequestPageContent.jsx 100.00% <ø> (ø)
.../pages/RepoPage/PullsTab/PullsTable/PullsTable.jsx 100.00% <ø> (ø)
...pages/RepoPage/PullsTab/PullsTable/Title/Title.jsx 100.00% <100.00%> (ø)
src/shared/utils/comparison.js 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1e1888...ec8100f. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #2289 (ec8100f) into main (d1e1888) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2289   +/-   ##
=====================================
  Coverage   98.04   98.04           
=====================================
  Files        703     703           
  Lines       8151    8154    +3     
  Branches    1965    1968    +3     
=====================================
+ Hits        7991    7994    +3     
  Misses       158     158           
  Partials       2       2           
Files Coverage Δ
...PullRequestPageContent/ErrorBanner/ErrorBanner.jsx 100.00% <ø> (ø)
.../PullRequestPageContent/PullRequestPageContent.jsx 100.00% <ø> (ø)
.../pages/RepoPage/PullsTab/PullsTable/PullsTable.jsx 100.00% <ø> (ø)
...pages/RepoPage/PullsTab/PullsTable/Title/Title.jsx 100.00% <100.00%> (ø)
src/shared/utils/comparison.js 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1e1888...ec8100f. Read the comment docs.

@codecov-public-qa
Copy link

codecov-public-qa bot commented Sep 26, 2023

Codecov Report

Merging #2289 (ec8100f) into main (587432e) will increase coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2289      +/-   ##
==========================================
+ Coverage   34.58%   34.60%   +0.02%     
==========================================
  Files         655      655              
  Lines        8015     8010       -5     
  Branches     1920     1921       +1     
==========================================
  Hits         2772     2772              
+ Misses       5220     5215       -5     
  Partials       23       23              
Files Changed Coverage Δ
src/App.jsx 0.00% <ø> (ø)
src/layouts/BaseLayout/hooks/useUserAccessGate.js 0.00% <0.00%> (ø)
src/pages/LoginPage/LoginButton.jsx 0.00% <ø> (ø)
src/pages/LoginPage/LoginPage.jsx 0.00% <ø> (ø)
...PullRequestPageContent/ErrorBanner/ErrorBanner.jsx 0.00% <ø> (ø)
.../PullRequestPageContent/PullRequestPageContent.jsx 0.00% <ø> (ø)
.../pages/RepoPage/PullsTab/PullsTable/PullsTable.jsx 0.00% <ø> (ø)
...pages/RepoPage/PullsTab/PullsTable/Title/Title.jsx 0.00% <0.00%> (ø)
src/pages/SyncProviderPage/SyncProviderPage.tsx 0.00% <0.00%> (ø)
src/shared/utils/comparison.js 0.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1e1888...ec8100f. Read the comment docs.

@netlify
Copy link

netlify bot commented Sep 26, 2023

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit ec8100f
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/65140a46eef56c0008feaaaa
😎 Deploy Preview https://deploy-preview-2289--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@RulaKhaled RulaKhaled merged commit f595c61 into main Sep 27, 2023
30 of 31 checks passed
@RulaKhaled RulaKhaled deleted the default-to-file-explorer branch September 27, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants