Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: More issues with spreading unions in GQL queries #2293

Conversation

nicholas-codecov
Copy link
Contributor

Description

Quick fix moving some union spreads up a level.

@codecov-staging
Copy link

codecov-staging bot commented Sep 28, 2023

Codecov Report

Merging #2293 (604c21f) into main (9e75c2b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2293   +/-   ##
=======================================
  Coverage   98.02%   98.02%           
=======================================
  Files         704      704           
  Lines        8207     8207           
  Branches     1963     1980   +17     
=======================================
  Hits         8045     8045           
  Misses        160      160           
  Partials        2        2           
Files Coverage Δ
src/services/commits/useCommits.js 100.00% <ø> (ø)
src/services/comparison/constants.js 100.00% <ø> (ø)
...omparison/useComparisonForCommitAndParent/query.js 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e75c2b...604c21f. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #2293 (604c21f) into main (9e75c2b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2293   +/-   ##
=====================================
  Coverage   98.03   98.03           
=====================================
  Files        704     704           
  Lines       8207    8207           
  Branches    1973    1980    +7     
=====================================
  Hits        8045    8045           
  Misses       160     160           
  Partials       2       2           
Files Coverage Δ
src/services/commits/useCommits.js 100.00% <ø> (ø)
src/services/comparison/constants.js 100.00% <ø> (ø)
...omparison/useComparisonForCommitAndParent/query.js 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e75c2b...604c21f. Read the comment docs.

@netlify
Copy link

netlify bot commented Sep 28, 2023

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 604c21f
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/6515881d90e46c0009052793
😎 Deploy Preview https://deploy-preview-2293--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-public-qa
Copy link

codecov-public-qa bot commented Sep 28, 2023

Codecov Report

Merging #2293 (604c21f) into main (9e75c2b) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2293      +/-   ##
==========================================
+ Coverage   34.16%   34.17%   +0.01%     
==========================================
  Files         655      655              
  Lines        8059     8059              
  Branches     1930     1930              
==========================================
+ Hits         2753     2754       +1     
+ Misses       5283     5282       -1     
  Partials       23       23              
Files Changed Coverage Δ
src/services/commits/useCommits.js 100.00% <ø> (ø)
src/services/comparison/constants.js 100.00% <ø> (ø)
...omparison/useComparisonForCommitAndParent/query.js 100.00% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e75c2b...604c21f. Read the comment docs.

@nicholas-codecov nicholas-codecov merged commit 27f89e9 into main Sep 28, 2023
31 checks passed
@nicholas-codecov nicholas-codecov deleted the fix-more-query-issues-with-incorrect-placing-of-union-spreads branch September 28, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants