Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update CommitDetailPage Links to Include Query Params #2297

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR adds in some minor changes to append query params along to various links that are used in the CommitDetailPage.

Closes codecov/engineering-team#582

Notable Changes

  • Update links in useNavLinks
  • Update CommitFileEntry to pass along flags from filters prop
  • Update CommitDirEntry to pass along flags from filters prop
  • Update CommitDetailPageTabs to pull query params
  • Update tests

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #2297 (3a06729) into main (2376ada) will increase coverage by 0.18%.
The diff coverage is 80.39%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2297     +/-   ##
=======================================
+ Coverage   34.15   34.33   +0.18     
=======================================
  Files        656     656             
  Lines       8065    8096     +31     
  Branches    1962    1942     -20     
=======================================
+ Hits        2754    2779     +25     
- Misses      5282    5294     +12     
+ Partials      29      23      -6     
Files Coverage Δ
...ilFileExplorer/hooks/useRepoCommitContentsTable.js 86.36% <ø> (ø)
...ontentsTable/TableEntries/BaseEntries/DirEntry.jsx 16.66% <ø> (+2.38%) ⬆️
...ntentsTable/TableEntries/BaseEntries/FileEntry.jsx 16.66% <ø> (+0.87%) ⬆️
...ble/TableEntries/CommitEntries/CommitFileEntry.jsx 20.00% <ø> (ø)
src/shared/treePaths/useCommitTreePath.js 100.00% <100.00%> (ø)
src/shared/treePaths/useTreePaths.js 100.00% <100.00%> (ø)
...able/TableEntries/CommitEntries/CommitDirEntry.jsx 20.00% <0.00%> (-5.00%) ⬇️
src/services/navigation/useNavLinks/useNavLinks.js 90.24% <94.28%> (+1.51%) ⬆️
...Page/CommitDetailPageTabs/CommitDetailPageTabs.jsx 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2376ada...3a06729. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Oct 3, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@2376ada). Click here to learn what that means.
The diff coverage is 96.07%.

❗ Current head 222032c differs from pull request most recent head 3a06729. Consider uploading reports for the commit 3a06729 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2297   +/-   ##
=======================================
  Coverage        ?   98.01%           
=======================================
  Files           ?      705           
  Lines           ?     8244           
  Branches        ?     1944           
=======================================
  Hits            ?     8080           
  Misses          ?      162           
  Partials        ?        2           
Files Coverage Δ
...Page/CommitDetailPageTabs/CommitDetailPageTabs.jsx 100.00% <100.00%> (ø)
...ilFileExplorer/hooks/useRepoCommitContentsTable.js 100.00% <ø> (ø)
...ontentsTable/TableEntries/BaseEntries/DirEntry.jsx 100.00% <ø> (ø)
...ntentsTable/TableEntries/BaseEntries/FileEntry.jsx 94.44% <ø> (ø)
...able/TableEntries/CommitEntries/CommitDirEntry.jsx 100.00% <100.00%> (ø)
...ble/TableEntries/CommitEntries/CommitFileEntry.jsx 100.00% <ø> (ø)
src/shared/treePaths/useCommitTreePath.js 100.00% <100.00%> (ø)
src/shared/treePaths/useTreePaths.js 100.00% <100.00%> (ø)
src/services/navigation/useNavLinks/useNavLinks.js 98.78% <94.28%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2376ada...3a06729. Read the comment docs.

@netlify
Copy link

netlify bot commented Oct 3, 2023

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 3a06729
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/651e8b171903030008a7ac42
😎 Deploy Preview https://deploy-preview-2297--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-qa
Copy link

codecov-qa bot commented Oct 3, 2023

Codecov Report

Merging #2297 (3a06729) into main (2376ada) will increase coverage by 0.17%.
The diff coverage is 80.39%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2297      +/-   ##
==========================================
+ Coverage   34.14%   34.32%   +0.17%     
==========================================
  Files         656      656              
  Lines        8065     8096      +31     
  Branches     1979     1944      -35     
==========================================
+ Hits         2754     2779      +25     
- Misses       5282     5294      +12     
+ Partials       29       23       -6     
Files Coverage Δ
...ilFileExplorer/hooks/useRepoCommitContentsTable.js 86.36% <ø> (ø)
...ontentsTable/TableEntries/BaseEntries/DirEntry.jsx 16.66% <ø> (+2.38%) ⬆️
...ntentsTable/TableEntries/BaseEntries/FileEntry.jsx 16.66% <ø> (+0.87%) ⬆️
...ble/TableEntries/CommitEntries/CommitFileEntry.jsx 20.00% <ø> (ø)
src/shared/treePaths/useCommitTreePath.js 100.00% <100.00%> (ø)
src/shared/treePaths/useTreePaths.js 100.00% <100.00%> (ø)
...able/TableEntries/CommitEntries/CommitDirEntry.jsx 20.00% <0.00%> (-5.00%) ⬇️
src/services/navigation/useNavLinks/useNavLinks.js 90.24% <94.28%> (+1.51%) ⬆️
...Page/CommitDetailPageTabs/CommitDetailPageTabs.jsx 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2376ada...3a06729. Read the comment docs.

@codecov-public-qa
Copy link

codecov-public-qa bot commented Oct 3, 2023

Codecov Report

Merging #2297 (3a06729) into main (2376ada) will increase coverage by 0.17%.
The diff coverage is 80.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2297      +/-   ##
==========================================
+ Coverage   34.14%   34.32%   +0.17%     
==========================================
  Files         656      656              
  Lines        8065     8096      +31     
  Branches     1979     1975       -4     
==========================================
+ Hits         2754     2779      +25     
- Misses       5282     5288       +6     
  Partials       29       29              
Files Coverage Δ
...ilFileExplorer/hooks/useRepoCommitContentsTable.js 86.36% <ø> (ø)
...ontentsTable/TableEntries/BaseEntries/DirEntry.jsx 16.66% <ø> (+2.38%) ⬆️
...ntentsTable/TableEntries/BaseEntries/FileEntry.jsx 16.66% <ø> (+0.87%) ⬆️
...ble/TableEntries/CommitEntries/CommitFileEntry.jsx 20.00% <ø> (ø)
src/shared/treePaths/useCommitTreePath.js 100.00% <100.00%> (ø)
src/shared/treePaths/useTreePaths.js 100.00% <100.00%> (ø)
...able/TableEntries/CommitEntries/CommitDirEntry.jsx 20.00% <0.00%> (-5.00%) ⬇️
src/services/navigation/useNavLinks/useNavLinks.js 90.24% <94.28%> (+1.51%) ⬆️
...Page/CommitDetailPageTabs/CommitDetailPageTabs.jsx 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2376ada...3a06729. Read the comment docs.

@nicholas-codecov nicholas-codecov merged commit 1ec6418 into main Oct 5, 2023
29 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-582-update-commit-detail-page-links-to-include-query-params branch October 5, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update links to pass along query params in CommitDetail
2 participants