-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update CommitDetailPage Links to Include Query Params #2297
feat: Update CommitDetailPage Links to Include Query Params #2297
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2297 +/- ##
=======================================
+ Coverage 34.15 34.33 +0.18
=======================================
Files 656 656
Lines 8065 8096 +31
Branches 1962 1942 -20
=======================================
+ Hits 2754 2779 +25
- Misses 5282 5294 +12
+ Partials 29 23 -6
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Codecov Report
@@ Coverage Diff @@
## main #2297 +/- ##
=======================================
Coverage ? 98.01%
=======================================
Files ? 705
Lines ? 8244
Branches ? 1944
=======================================
Hits ? 8080
Misses ? 162
Partials ? 2
Continue to review full report in Codecov by Sentry.
|
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2297 +/- ##
==========================================
+ Coverage 34.14% 34.32% +0.17%
==========================================
Files 656 656
Lines 8065 8096 +31
Branches 1979 1944 -35
==========================================
+ Hits 2754 2779 +25
- Misses 5282 5294 +12
+ Partials 29 23 -6
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Codecov Report
@@ Coverage Diff @@
## main #2297 +/- ##
==========================================
+ Coverage 34.14% 34.32% +0.17%
==========================================
Files 656 656
Lines 8065 8096 +31
Branches 1979 1975 -4
==========================================
+ Hits 2754 2779 +25
- Misses 5282 5288 +6
Partials 29 29
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…o-include-query-params
…o-include-query-params
… default query params
…o-include-query-params
Description
This PR adds in some minor changes to append query params along to various links that are used in the
CommitDetailPage
.Closes codecov/engineering-team#582
Notable Changes
useNavLinks
CommitFileEntry
to pass alongflags
fromfilters
propCommitDirEntry
to pass alongflags
fromfilters
propCommitDetailPageTabs
to pull query params