Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Update useCommit to Use New impactedFiles Resolver #2316

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR updates the current useCommit hook to use the updated impactedFiles resolver so that we can continue working on adding flag selection support to the commit detail page.

Closes codecov/engineering-team#673

Notable Changes

  • Update useCommit to use the new impactedFiles resolver
  • Update FilesChangedTable to check for new __typename instances
  • Update IndirectChangesTable to check for new __typename instances
  • Create new UnkownFlags schema type
  • Update various tests

@codecov-public-qa
Copy link

codecov-public-qa bot commented Oct 17, 2023

Codecov Report

Merging #2316 (0e438b7) into main (486fa91) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2316      +/-   ##
==========================================
- Coverage   97.42%   97.41%   -0.01%     
==========================================
  Files         715      716       +1     
  Lines        8509     8519      +10     
  Branches     2089     2094       +5     
==========================================
+ Hits         8290     8299       +9     
- Misses        216      217       +1     
  Partials        3        3              
Files Coverage Δ
...ChangedTab/FilesChangedTable/FilesChangedTable.jsx 100.00% <100.00%> (ø)
...sTab/IndirectChangesTable/IndirectChangesTable.jsx 100.00% <100.00%> (ø)
src/services/commit/useCommit.tsx 98.00% <100.00%> (-2.00%) ⬇️
src/services/impactedFiles/schemas/UnknownFlags.ts 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 486fa91...0e438b7. Read the comment docs.

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #2316 (0e438b7) into main (486fa91) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2316     +/-   ##
=======================================
- Coverage   97.43   97.42   -0.01     
=======================================
  Files        715     716      +1     
  Lines       8509    8519     +10     
  Branches    2089    2087      -2     
=======================================
+ Hits        8290    8299      +9     
- Misses       216     217      +1     
  Partials       3       3             
Files Coverage Δ
...ChangedTab/FilesChangedTable/FilesChangedTable.jsx 100.00% <100.00%> (ø)
...sTab/IndirectChangesTable/IndirectChangesTable.jsx 100.00% <100.00%> (ø)
src/services/commit/useCommit.tsx 98.00% <100.00%> (-2.00%) ⬇️
src/services/impactedFiles/schemas/UnknownFlags.ts 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 486fa91...0e438b7. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Oct 17, 2023

Codecov Report

Merging #2316 (0e438b7) into main (486fa91) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2316      +/-   ##
==========================================
- Coverage   97.42%   97.41%   -0.01%     
==========================================
  Files         715      716       +1     
  Lines        8509     8519      +10     
  Branches     2082     2087       +5     
==========================================
+ Hits         8290     8299       +9     
  Misses        217      217              
- Partials        2        3       +1     
Files Coverage Δ
...ChangedTab/FilesChangedTable/FilesChangedTable.jsx 100.00% <100.00%> (ø)
...sTab/IndirectChangesTable/IndirectChangesTable.jsx 100.00% <100.00%> (ø)
src/services/commit/useCommit.tsx 98.00% <100.00%> (-2.00%) ⬇️
src/services/impactedFiles/schemas/UnknownFlags.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 486fa91...0e438b7. Read the comment docs.

@netlify
Copy link

netlify bot commented Oct 17, 2023

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 0e438b7
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/65328c48f570030007731326
😎 Deploy Preview https://deploy-preview-2316--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@terry-codecov terry-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, side note one test failed maybe needs to resync with main to get those test suite updates?

src/pages/CommitDetailPage/CommitDetailPage.spec.jsx line 207

@codecov-staging
Copy link

codecov-staging bot commented Oct 20, 2023

Codecov Report

Merging #2316 (0e438b7) into main (486fa91) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2316      +/-   ##
==========================================
- Coverage   97.42%   97.41%   -0.01%     
==========================================
  Files         715      716       +1     
  Lines        8509     8519      +10     
  Branches     2040     2045       +5     
==========================================
+ Hits         8290     8299       +9     
- Misses        217      218       +1     
  Partials        2        2              
Files Coverage Δ
...ChangedTab/FilesChangedTable/FilesChangedTable.jsx 100.00% <100.00%> (ø)
...sTab/IndirectChangesTable/IndirectChangesTable.jsx 100.00% <100.00%> (ø)
src/services/commit/useCommit.tsx 98.00% <100.00%> (-2.00%) ⬇️
src/services/impactedFiles/schemas/UnknownFlags.ts 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 486fa91...0e438b7. Read the comment docs.

@nicholas-codecov nicholas-codecov merged commit 00c8a85 into main Oct 20, 2023
29 of 33 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-673-update-useCommit-to-use-new-impacted-files-resolver branch October 20, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update useCommit to use new impacted files
2 participants