Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add conditional to exclude static/profiling token #2317

Merged
merged 8 commits into from
Oct 18, 2023

Conversation

adrian-codecov
Copy link
Contributor

@adrian-codecov adrian-codecov commented Oct 17, 2023

Description

We want to exclude the static/impact analysis tokens for team tier customers. This change does that.

Notable Changes

  • Create new file + hooks for team specific token list
  • Adjusts tests
  • Adjust GeneralTab to display either tokens or tokensTeam component
  • Add hooks folder for specific hooks

Screenshots

Without
Screenshot 2023-10-17 at 4 20 38 PM

With
Screenshot 2023-10-17 at 4 20 57 PM

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@netlify
Copy link

netlify bot commented Oct 17, 2023

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit c55661a
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/653042a8361d3500075ed60c
😎 Deploy Preview https://deploy-preview-2317--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-public-qa
Copy link

codecov-public-qa bot commented Oct 17, 2023

Codecov Report

Merging #2317 (c55661a) into main (817c0d2) will increase coverage by 0.02%.
The diff coverage is 35.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2317      +/-   ##
==========================================
+ Coverage   33.88%   33.90%   +0.02%     
==========================================
  Files         657      660       +3     
  Lines        8236     8269      +33     
  Branches     2013     2019       +6     
==========================================
+ Hits         2791     2804      +13     
- Misses       5423     5443      +20     
  Partials       22       22              
Files Coverage Δ
...b/tabs/GeneralTab/Tokens/TokensTeam/TokensTeam.jsx 100.00% <100.00%> (ø)
src/services/repo/useRepoSettingsTeam.js 100.00% <100.00%> (ø)
...epoPage/SettingsTab/tabs/GeneralTab/GeneralTab.jsx 0.00% <0.00%> (ø)
...Tab/tabs/GeneralTab/hooks/useRepoDefaultBranch.tsx 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 817c0d2...c55661a. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Oct 17, 2023

Codecov Report

Merging #2317 (c55661a) into main (817c0d2) will increase coverage by 0.02%.
The diff coverage is 35.13%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2317      +/-   ##
==========================================
+ Coverage   33.88%   33.90%   +0.02%     
==========================================
  Files         657      660       +3     
  Lines        8236     8269      +33     
  Branches     2057     2021      -36     
==========================================
+ Hits         2791     2804      +13     
- Misses       5416     5443      +27     
+ Partials       29       22       -7     
Files Coverage Δ
...b/tabs/GeneralTab/Tokens/TokensTeam/TokensTeam.jsx 100.00% <100.00%> (ø)
src/services/repo/useRepoSettingsTeam.js 100.00% <100.00%> (ø)
...epoPage/SettingsTab/tabs/GeneralTab/GeneralTab.jsx 0.00% <0.00%> (ø)
...Tab/tabs/GeneralTab/hooks/useRepoDefaultBranch.tsx 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 817c0d2...c55661a. Read the comment docs.

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #2317 (c55661a) into main (817c0d2) will increase coverage by 0.02%.
The diff coverage is 35.13%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2317     +/-   ##
=======================================
+ Coverage   33.89   33.91   +0.02     
=======================================
  Files        657     660      +3     
  Lines       8236    8269     +33     
  Branches    2013    2063     +50     
=======================================
+ Hits        2791    2804     +13     
- Misses      5423    5436     +13     
- Partials      22      29      +7     
Files Coverage Δ
...b/tabs/GeneralTab/Tokens/TokensTeam/TokensTeam.jsx 100.00% <100.00%> (ø)
src/services/repo/useRepoSettingsTeam.js 100.00% <100.00%> (ø)
...epoPage/SettingsTab/tabs/GeneralTab/GeneralTab.jsx 0.00% <0.00%> (ø)
...Tab/tabs/GeneralTab/hooks/useRepoDefaultBranch.tsx 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 817c0d2...c55661a. Read the comment docs.

Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments to take a peak at

Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, ship it ✅

@adrian-codecov adrian-codecov merged commit 2a43d7f into main Oct 18, 2023
29 of 30 checks passed
@adrian-codecov adrian-codecov deleted the 607-hide-impact-and-static-tokens-for-team-tier branch October 18, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants