-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add conditional to exclude static/profiling token #2317
feat: add conditional to exclude static/profiling token #2317
Conversation
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## main #2317 +/- ##
==========================================
+ Coverage 33.88% 33.90% +0.02%
==========================================
Files 657 660 +3
Lines 8236 8269 +33
Branches 2013 2019 +6
==========================================
+ Hits 2791 2804 +13
- Misses 5423 5443 +20
Partials 22 22
Continue to review full report in Codecov by Sentry.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2317 +/- ##
==========================================
+ Coverage 33.88% 33.90% +0.02%
==========================================
Files 657 660 +3
Lines 8236 8269 +33
Branches 2057 2021 -36
==========================================
+ Hits 2791 2804 +13
- Misses 5416 5443 +27
+ Partials 29 22 -7
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Codecov Report
@@ Coverage Diff @@
## main #2317 +/- ##
=======================================
+ Coverage 33.89 33.91 +0.02
=======================================
Files 657 660 +3
Lines 8236 8269 +33
Branches 2013 2063 +50
=======================================
+ Hits 2791 2804 +13
- Misses 5423 5436 +13
- Partials 22 29 +7
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments to take a peak at
src/pages/RepoPage/SettingsTab/tabs/GeneralTab/Tokens/TokensTeam/hooks/useRepoSettingsTeam.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, ship it ✅
…e-impact-and-static-tokens-for-team-tier
Description
We want to exclude the static/impact analysis tokens for team tier customers. This change does that.
Notable Changes
Screenshots
Without
With
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.