Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create New usePullsTeam Hook #2319

Merged
merged 4 commits into from
Oct 19, 2023

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR creates a new hook that fetches a list of pulls with only the information required for the new team plan.

Closes codecov/engineering-team#679

Notable Changes

  • Create new usePullsTeam hook
  • Create tests for new hook

@netlify
Copy link

netlify bot commented Oct 18, 2023

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 4070586
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/653112416b81470008f57c9f
😎 Deploy Preview https://deploy-preview-2319--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #2319 (4070586) into main (2a43d7f) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2319     +/-   ##
=======================================
- Coverage   33.91   33.80   -0.11     
=======================================
  Files        660     661      +1     
  Lines       8269    8294     +25     
  Branches    2070    2025     -45     
=======================================
- Hits        2804    2803      -1     
- Misses      5436    5469     +33     
+ Partials      29      22      -7     
Files Coverage Δ
src/services/pulls/usePullsTeam.tsx 0.00% <0.00%> (ø)

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a43d7f...4070586. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Oct 18, 2023

Codecov Report

Merging #2319 (c302bcd) into main (2a43d7f) will increase coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head c302bcd differs from pull request most recent head 4070586. Consider uploading reports for the commit 4070586 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2319      +/-   ##
==========================================
+ Coverage   33.90%   33.92%   +0.01%     
==========================================
  Files         660      658       -2     
  Lines        8269     8227      -42     
  Branches     2052     2005      -47     
==========================================
- Hits         2804     2791      -13     
+ Misses       5436     5414      -22     
+ Partials       29       22       -7     
Files Coverage Δ
src/services/pulls/usePullsTeam.tsx 0.00% <0.00%> (ø)

... and 17 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a43d7f...4070586. Read the comment docs.

@codecov-public-qa
Copy link

codecov-public-qa bot commented Oct 18, 2023

Codecov Report

Merging #2319 (4070586) into main (2a43d7f) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2319      +/-   ##
==========================================
- Coverage   33.90%   33.79%   -0.12%     
==========================================
  Files         660      661       +1     
  Lines        8269     8294      +25     
  Branches     2070     2069       -1     
==========================================
- Hits         2804     2803       -1     
- Misses       5436     5469      +33     
+ Partials       29       22       -7     
Files Coverage Δ
src/services/pulls/usePullsTeam.tsx 0.00% <0.00%> (ø)

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a43d7f...4070586. Read the comment docs.

Copy link
Contributor

@adrian-codecov adrian-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, mainly checked that head.totals.percentCovered + changeCoverage weren't present as this was a mirror of other code 👌

@codecov-staging
Copy link

codecov-staging bot commented Oct 19, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@2a43d7f). Click here to learn what that means.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2319   +/-   ##
=======================================
  Coverage        ?   33.79%           
=======================================
  Files           ?      661           
  Lines           ?     8294           
  Branches        ?     2025           
=======================================
  Hits            ?     2803           
  Misses          ?     5469           
  Partials        ?       22           
Files Coverage Δ
src/services/pulls/usePullsTeam.tsx 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a43d7f...4070586. Read the comment docs.

@nicholas-codecov nicholas-codecov merged commit 3db2ed5 into main Oct 19, 2023
23 of 30 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-679-create-new-use-pulls-team-hook branch October 19, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create New usePullsTeam Hook
2 participants