Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

625 remove flags page for team tier #2330

Merged
merged 4 commits into from
Oct 19, 2023

Conversation

adrian-codecov
Copy link
Contributor

Description

We're hiding the flags over time tab for team tier customers.

Notable Changes

  • Hide flags tab for team tier customers
  • Add redirect to flags tab in case user enters via url
  • Adjust input data for other tests
  • Write tests

Screenshots

Screenshot 2023-10-19 at 9 00 31 AM

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-staging
Copy link

codecov-staging bot commented Oct 19, 2023

Codecov Report

Merging #2330 (ebff54b) into main (53e6b17) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2330      +/-   ##
==========================================
- Coverage   33.62%   33.58%   -0.05%     
==========================================
  Files         664      664              
  Lines        8359     8369      +10     
  Branches     2071     2093      +22     
==========================================
  Hits         2811     2811              
- Misses       5519     5529      +10     
  Partials       29       29              
Files Coverage Δ
src/pages/RepoPage/FlagsTab/FlagsTab.jsx 0.00% <0.00%> (ø)
src/pages/RepoPage/RepoPage.jsx 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53e6b17...ebff54b. Read the comment docs.

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #2330 (ebff54b) into main (53e6b17) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2330     +/-   ##
=======================================
- Coverage   33.63   33.59   -0.04     
=======================================
  Files        664     664             
  Lines       8359    8369     +10     
  Branches    2082    2042     -40     
=======================================
  Hits        2811    2811             
- Misses      5526    5536     +10     
  Partials      22      22             
Files Coverage Δ
src/pages/RepoPage/FlagsTab/FlagsTab.jsx 0.00% <0.00%> (ø)
src/pages/RepoPage/RepoPage.jsx 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53e6b17...ebff54b. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Oct 19, 2023

Codecov Report

Merging #2330 (ebff54b) into main (53e6b17) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2330      +/-   ##
==========================================
- Coverage   33.62%   33.58%   -0.05%     
==========================================
  Files         664      664              
  Lines        8359     8369      +10     
  Branches     2082     2086       +4     
==========================================
  Hits         2811     2811              
- Misses       5526     5536      +10     
  Partials       22       22              
Files Coverage Δ
src/pages/RepoPage/FlagsTab/FlagsTab.jsx 0.00% <0.00%> (ø)
src/pages/RepoPage/RepoPage.jsx 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53e6b17...ebff54b. Read the comment docs.

@codecov-public-qa
Copy link

codecov-public-qa bot commented Oct 19, 2023

Codecov Report

Merging #2330 (ebff54b) into main (53e6b17) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2330      +/-   ##
==========================================
- Coverage   33.62%   33.58%   -0.05%     
==========================================
  Files         664      664              
  Lines        8359     8369      +10     
  Branches     2038     2044       +6     
==========================================
  Hits         2811     2811              
- Misses       5526     5536      +10     
  Partials       22       22              
Files Coverage Δ
src/pages/RepoPage/FlagsTab/FlagsTab.jsx 0.00% <0.00%> (ø)
src/pages/RepoPage/RepoPage.jsx 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53e6b17...ebff54b. Read the comment docs.

@netlify
Copy link

netlify bot commented Oct 19, 2023

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit ebff54b
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/653166803d5f650009e2a878
😎 Deploy Preview https://deploy-preview-2330--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quick small thing to fix up some tests descriptions

Comment on lines 96 to 109
describe('when user has a team tier', () => {
beforeEach(() => {
setup({ multipleTiers: true })
})

it('renders a blurred image of the table', async () => {
render(<FlagsTab />, { wrapper })

await waitFor(() =>
expect(testLocation.pathname).toBe('/gh/codecov/gazebo')
)
})
})

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure these test descriptions align with whats being tested here 👀

Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me thanks for that quick fix 👍

@adrian-codecov adrian-codecov merged commit 84b4af6 into main Oct 19, 2023
21 of 30 checks passed
@adrian-codecov adrian-codecov deleted the 625-remove-flags-page-for-team-tier branch October 19, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants