Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team flags refactor #2331

Merged
merged 4 commits into from
Oct 19, 2023
Merged

Team flags refactor #2331

merged 4 commits into from
Oct 19, 2023

Conversation

adrian-codecov
Copy link
Contributor

Description

Getting rid of some feature flags that aren't needed as part of code removal

Notable Changes

  • Getting rid of redundant feature flags

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@netlify
Copy link

netlify bot commented Oct 19, 2023

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 7fb50e2
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/65318e1d0916850008c6dc9f
😎 Deploy Preview https://deploy-preview-2331--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-staging
Copy link

codecov-staging bot commented Oct 19, 2023

Codecov Report

Merging #2331 (7fb50e2) into main (7833ceb) will increase coverage by 12.76%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2331       +/-   ##
===========================================
+ Coverage   84.66%   97.42%   +12.76%     
===========================================
  Files         713      715        +2     
  Lines        8517     8509        -8     
  Branches     2093     2082       -11     
===========================================
+ Hits         7211     8290     +1079     
+ Misses       1280      217     -1063     
+ Partials       26        2       -24     
Files Coverage Δ
src/pages/AccountSettings/shared/Header/Header.jsx 100.00% <100.00%> (+100.00%) ⬆️
src/pages/AnalyticsPage/AnalyticsPage.jsx 100.00% <100.00%> (+100.00%) ⬆️
src/pages/AnalyticsPage/Tabs/Tabs.jsx 100.00% <100.00%> (+100.00%) ⬆️
src/pages/MembersPage/Tabs/Tabs.jsx 100.00% <100.00%> (ø)
src/pages/OwnerPage/Tabs/Tabs.jsx 100.00% <100.00%> (ø)
src/pages/PlanPage/Tabs/Tabs.jsx 100.00% <100.00%> (ø)
src/pages/RepoPage/FlagsTab/FlagsTab.jsx 100.00% <100.00%> (ø)
src/pages/RepoPage/RepoPage.jsx 100.00% <100.00%> (ø)
...epoPage/SettingsTab/tabs/GeneralTab/GeneralTab.jsx 100.00% <100.00%> (ø)

... and 85 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7833ceb...7fb50e2. Read the comment docs.

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #2331 (7fb50e2) into main (7833ceb) will increase coverage by 12.76%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##            main   #2331      +/-   ##
========================================
+ Coverage   84.67   97.43   +12.76     
========================================
  Files        713     715       +2     
  Lines       8517    8509       -8     
  Branches    2093    2071      -22     
========================================
+ Hits        7211    8290    +1079     
+ Misses      1280     216    -1064     
+ Partials      26       3      -23     
Files Coverage Δ
src/pages/AccountSettings/shared/Header/Header.jsx 100.00% <100.00%> (+100.00%) ⬆️
src/pages/AnalyticsPage/AnalyticsPage.jsx 100.00% <100.00%> (+100.00%) ⬆️
src/pages/AnalyticsPage/Tabs/Tabs.jsx 100.00% <100.00%> (+100.00%) ⬆️
src/pages/MembersPage/Tabs/Tabs.jsx 100.00% <100.00%> (ø)
src/pages/OwnerPage/Tabs/Tabs.jsx 100.00% <100.00%> (ø)
src/pages/PlanPage/Tabs/Tabs.jsx 100.00% <100.00%> (ø)
src/pages/RepoPage/FlagsTab/FlagsTab.jsx 100.00% <100.00%> (ø)
src/pages/RepoPage/RepoPage.jsx 100.00% <100.00%> (ø)
...epoPage/SettingsTab/tabs/GeneralTab/GeneralTab.jsx 100.00% <100.00%> (ø)

... and 84 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7833ceb...7fb50e2. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Oct 19, 2023

Codecov Report

Merging #2331 (7fb50e2) into main (7833ceb) will increase coverage by 12.76%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2331       +/-   ##
===========================================
+ Coverage   84.66%   97.42%   +12.76%     
===========================================
  Files         713      715        +2     
  Lines        8517     8509        -8     
  Branches     2044     2071       +27     
===========================================
+ Hits         7211     8290     +1079     
+ Misses       1282      216     -1066     
+ Partials       24        3       -21     
Files Coverage Δ
src/pages/AccountSettings/shared/Header/Header.jsx 100.00% <100.00%> (+100.00%) ⬆️
src/pages/AnalyticsPage/AnalyticsPage.jsx 100.00% <100.00%> (+100.00%) ⬆️
src/pages/AnalyticsPage/Tabs/Tabs.jsx 100.00% <100.00%> (+100.00%) ⬆️
src/pages/MembersPage/Tabs/Tabs.jsx 100.00% <100.00%> (ø)
src/pages/OwnerPage/Tabs/Tabs.jsx 100.00% <100.00%> (ø)
src/pages/PlanPage/Tabs/Tabs.jsx 100.00% <100.00%> (ø)
src/pages/RepoPage/FlagsTab/FlagsTab.jsx 100.00% <100.00%> (ø)
src/pages/RepoPage/RepoPage.jsx 100.00% <100.00%> (ø)
...epoPage/SettingsTab/tabs/GeneralTab/GeneralTab.jsx 100.00% <100.00%> (ø)

... and 85 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7833ceb...7fb50e2. Read the comment docs.

@codecov-public-qa
Copy link

codecov-public-qa bot commented Oct 19, 2023

Codecov Report

Merging #2331 (7fb50e2) into main (7833ceb) will increase coverage by 12.76%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2331       +/-   ##
===========================================
+ Coverage   84.66%   97.42%   +12.76%     
===========================================
  Files         713      715        +2     
  Lines        8517     8509        -8     
  Branches     2042     2082       +40     
===========================================
+ Hits         7211     8290     +1079     
+ Misses       1282      217     -1065     
+ Partials       24        2       -22     
Files Coverage Δ
src/pages/AccountSettings/shared/Header/Header.jsx 100.00% <100.00%> (+100.00%) ⬆️
src/pages/AnalyticsPage/AnalyticsPage.jsx 100.00% <100.00%> (+100.00%) ⬆️
src/pages/AnalyticsPage/Tabs/Tabs.jsx 100.00% <100.00%> (+100.00%) ⬆️
src/pages/MembersPage/Tabs/Tabs.jsx 100.00% <100.00%> (ø)
src/pages/OwnerPage/Tabs/Tabs.jsx 100.00% <100.00%> (ø)
src/pages/PlanPage/Tabs/Tabs.jsx 100.00% <100.00%> (ø)
src/pages/RepoPage/FlagsTab/FlagsTab.jsx 100.00% <100.00%> (ø)
src/pages/RepoPage/RepoPage.jsx 100.00% <100.00%> (ø)
...epoPage/SettingsTab/tabs/GeneralTab/GeneralTab.jsx 100.00% <100.00%> (ø)

... and 84 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7833ceb...7fb50e2. Read the comment docs.

Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me 👍

@adrian-codecov adrian-codecov merged commit 1e18241 into main Oct 19, 2023
32 of 33 checks passed
@adrian-codecov adrian-codecov deleted the team-flags-refactor branch October 19, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants