Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cleaning up remaining flaky tests #2333

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

nicholas-codecov
Copy link
Contributor

Description

Trying to get rid of the last remaining flaky tests.

@netlify
Copy link

netlify bot commented Oct 20, 2023

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 1453b46
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/653259267a2ee00008ddc5d8
😎 Deploy Preview https://deploy-preview-2333--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-staging
Copy link

codecov-staging bot commented Oct 20, 2023

Codecov Report

Merging #2333 (1453b46) into main (1e18241) will increase coverage by 28.58%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2333       +/-   ##
===========================================
+ Coverage   68.84%   97.42%   +28.58%     
===========================================
  Files         711      715        +4     
  Lines        8499     8509       +10     
  Branches     2082     2082               
===========================================
+ Hits         5851     8290     +2439     
+ Misses       2584      217     -2367     
+ Partials       64        2       -62     

see 184 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e18241...1453b46. Read the comment docs.

@codecov-public-qa
Copy link

codecov-public-qa bot commented Oct 20, 2023

Codecov Report

Merging #2333 (1453b46) into main (1e18241) will increase coverage by 28.58%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2333       +/-   ##
===========================================
+ Coverage   68.84%   97.42%   +28.58%     
===========================================
  Files         711      715        +4     
  Lines        8499     8509       +10     
  Branches     2071     2038       -33     
===========================================
+ Hits         5851     8290     +2439     
+ Misses       2581      217     -2364     
+ Partials       67        2       -65     

see 185 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e18241...1453b46. Read the comment docs.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #2333 (1453b46) into main (1e18241) will increase coverage by 28.59%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##            main   #2333      +/-   ##
========================================
+ Coverage   68.84   97.43   +28.59     
========================================
  Files        711     715       +4     
  Lines       8499    8509      +10     
  Branches    2038    2089      +51     
========================================
+ Hits        5851    8290    +2439     
+ Misses      2584     216    -2368     
+ Partials      64       3      -61     

see 185 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e18241...1453b46. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Oct 20, 2023

Codecov Report

Merging #2333 (1453b46) into main (1e18241) will increase coverage by 28.58%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2333       +/-   ##
===========================================
+ Coverage   68.84%   97.42%   +28.58%     
===========================================
  Files         711      715        +4     
  Lines        8499     8509       +10     
  Branches     2089     2082        -7     
===========================================
+ Hits         5851     8290     +2439     
+ Misses       2581      216     -2365     
+ Partials       67        3       -64     

see 184 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e18241...1453b46. Read the comment docs.

@nicholas-codecov nicholas-codecov merged commit 486fa91 into main Oct 20, 2023
33 checks passed
@nicholas-codecov nicholas-codecov deleted the oct-20-flaky-test-fixes branch October 20, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants