Migrate TextInput to TypeScript #2342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitvinnakota-codecov
force-pushed
the
rvinnakota-migrate-textinput-ts
branch
from
51c35e6
to
b9464ca
Compare
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## main #2342 +/- ##
===========================================
+ Coverage 84.59% 97.13% +12.54%
===========================================
Files 721 723 +2
Lines 8626 8631 +5
Branches 2119 2126 +7
===========================================
+ Hits 7297 8384 +1087
+ Misses 1303 244 -1059
+ Partials 26 3 -23
... and 88 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2342 +/- ##
===========================================
+ Coverage 84.59% 97.13% +12.54%
===========================================
Files 721 723 +2
Lines 8626 8631 +5
Branches 2119 2108 -11
===========================================
+ Hits 7297 8384 +1087
+ Misses 1303 244 -1059
+ Partials 26 3 -23
... and 88 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Codecov Report
@@ Coverage Diff @@
## main #2342 +/- ##
========================================
+ Coverage 84.59 97.14 +12.55
========================================
Files 721 723 +2
Lines 8626 8631 +5
Branches 2125 2108 -17
========================================
+ Hits 7297 8384 +1087
+ Misses 1303 244 -1059
+ Partials 26 3 -23
... and 88 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -13,7 +13,7 @@ const iconComponentCollection = { | |||
| type IconCollection = typeof iconComponentCollection | |||
| type Variant = keyof IconCollection | |||
|
|
|||
| type OutlineIconCollection = typeof svgOutline | |||
| export type OutlineIconCollection = typeof svgOutline | |||
There was a problem hiding this comment.
Exported this type so I can declare a custom type in TextInput.tsx based on the keys of this collection. TextInput renders an Icon with an outline variant, which type checks against keys only in this collection.
rohitvinnakota-codecov
changed the title
terry-codecov
approved these changes
Oct 25, 2023
Codecov Report
@@ Coverage Diff @@
## main #2342 +/- ##
===========================================
+ Coverage 84.59% 97.13% +12.54%
===========================================
Files 721 723 +2
Lines 8626 8631 +5
Branches 2107 2108 +1
===========================================
+ Hits 7297 8384 +1087
+ Misses 1303 244 -1059
+ Partials 26 3 -23
... and 88 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
RulaKhaled
pushed a commit
that referenced
this pull request
Oct 31, 2023
* Migrate textinput to TS * Add story * formatting * organize imports
RulaKhaled
added a commit
that referenced
this pull request
Nov 3, 2023
* first pass, wheeeeeo * Sorting functionality * Update with tests * wrap up repos list: * Spelling correction (#2336) * 616 add patch setction pr page team tier (#2337) * feat: add header component for team tier customers * feat: converted Header.jsx to Header.tsx + tests * fix: add comparison schema types * fix: Filter out certain browser from sending events to Sentry (#2338) Filter out events for a given browser because they don't have all JS functions fully implemented causing issues that we cannot address. * feat: Hide Flag MultiSelect when on Team Plan on Commit Detail Page (#2327) We will need to hide the flag multi select on the commit detail page when the user is on the team plan as they are not an available feature to those users. GH codecov/engineering-team#687 * feat, ref: Disable Flag MultiSelect on Coverage Tab when on a Team Plan (#2329) Disable the flag multi-select on the coverage tab when users/orgs are on a team plan. GH codecov/engineering-team#685 * feat: Grab flags in IndirectChangesTable and pass along with request (#2335) Update indirect changes tab on the commit detail page to grab flags from the url params and pass along as query args. GH codecov/engineering-team#348 * feat: Update CommitDetailPage FilesChangedTable to pass along flags (#2334) Update the files changed tab on the commit detail page to grab flags url param and pass along as query args. GH codecov/engineering-team#347 * ref: Update TOS to work for service less users. (#2321) * Update with service less requests * Make sure hook supports service less * feat: Add Flag MultiSelect to CommitPageTabs (#2303) Add a feature flagged multi select to the CommitPageTabs component. GH codecov/engineering-team#344 * Add patch column to pulls table (#2308) * feat: add patch column to the pulls list page * uncomment development settings * feat: Create Team Plan Table for the Files Changed Table on the Commit Detail Page (#2309) Create new commit fetching hooks for the team plan, as well as creating a new table for files changed tab on the commit detail page for the new team plan. GH codecov/engineering-team#633 * Setup pull request page to pass around selected flags (#2282) * feat: setup pull request page to pass around selected flags in links * Feedback, fix passing links to files+folders, additional testing * fix file explorer test failing on href match due to new query param pass through * airplane commit, cant check local dev server: Resolve merge issues / tests + unify codebases missed of commitSHA and commitSha to just commitSha * Prevent multislect from collapsing + wire up PR details page to pass through flags links * Fix accidental removal of ref on usePrefetchPullFileEntry * Add patch column to pulls table (#2308) * feat: add patch column to the pulls list page * uncomment development settings * feat: Create Team Plan Table for the Files Changed Table on the Commit Detail Page (#2309) Create new commit fetching hooks for the team plan, as well as creating a new table for files changed tab on the commit detail page for the new team plan. GH codecov/engineering-team#633 --------- Co-authored-by: Adrian <adrian@codecov.io> Co-authored-by: nicholas-codecov <nicholas.deschenes@sentry.io> * chore: Remove segment from frontend (#2314) * Update with tests * test with support service less * adjust logic to handle original route * it's fine it works with no providers --------- Co-authored-by: nicholas-codecov <nicholas.deschenes@sentry.io> Co-authored-by: Adrian <adrian@codecov.io> Co-authored-by: Terry <87824812+terry-codecov@users.noreply.github.com> * restructure folders anticipating second header component for team tier (#2340) * feat: add hook for commit detail page team tier (#2341) * build: Update PostCSS (#2346) Update PostCSS dependency. * Migrate TextInput to TypeScript (#2342) * Migrate textinput to TS * Add story * formatting * organize imports * Connect flag selector to flags filter on PR details page (#2343) * feat: Update impacted files resolver for use pull, connect the flag selector to the api. * update missing logic as requested + unknown flags message to be aligned with repo overview design * Noticed the changing the pull query broke impacted files while smoke testing, dupicated the same compatibility work for the new resolver. * Refactor to use a impacted files enum as requested. * fix: Attempting to fix CommitDetailPage and RepoPage Tests (#2350) Addressing flaky tests in CommitDetailPage and RepoPage. * Add patch section commit detail page team tier (#2344) * restructure folders anticipating second header component for team tier * feat: add patch coverage section to commit detail page for team tier customer * fix: rename HeaderDefault to HeaderTeam for team file * Convert Sparkline to typescript (#2347) * Convert sparkline to typescript * Consistent type defs * better variable names * use enum * quick fixes * Update use memo * Update tests with getSortingOption * pull out the function of the test block --------- Co-authored-by: Joe Becher <joe@codecov.io> Co-authored-by: Adrian <adrian@codecov.io> Co-authored-by: nicholas-codecov <nicholas.deschenes@sentry.io> Co-authored-by: Terry <87824812+terry-codecov@users.noreply.github.com> Co-authored-by: Rohit Vinnakota <148245014+rohitvinnakota-codecov@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per codecov/engineering-team#518, migrates the TextInput component, tests, and stories to Typescript.
There are still references to
dataMarketingelsewhere in the code so I converted it directly to a string type in the component class. I checked existing usage of text boxes in the app and Storybook to verify the changes are working as intended.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.