Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update Repo Page Pulls Tab for Team Plan #2358

Merged
merged 15 commits into from
Nov 1, 2023

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR updates the pulls tab on the repo page to conditionally render the table depending on the repos visibility and the tier value for the org/user.

Closes codecov/engineering-team#615

Notable Changes

  • Create new function to compile table data
  • Create new PullsTableTeam component
  • Update PullsTab to conditionally render tables
  • Some TS migrations as well

Screenshots

Screenshot 2023-10-30 at 1 15 48 PM

@netlify
Copy link

netlify bot commented Oct 30, 2023

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 887dac0
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/653fd7302072290008534f4e
😎 Deploy Preview https://deploy-preview-2358--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-public-qa
Copy link

codecov-public-qa bot commented Oct 30, 2023

Codecov Report

Merging #2358 (3e3c115) into main (74b001c) will increase coverage by 0.00%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 3e3c115 differs from pull request most recent head 788a68d. Consider uploading reports for the commit 788a68d to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2358   +/-   ##
=======================================
  Coverage   97.15%   97.16%           
=======================================
  Files         725      728    +3     
  Lines        8681     8740   +59     
  Branches     2144     2158   +14     
=======================================
+ Hits         8434     8492   +58     
  Misses        245      245           
- Partials        2        3    +1     
Files Coverage Δ
src/pages/RepoPage/PullsTab/PullsTab.tsx 100.00% <100.00%> (ø)
...RepoPage/PullsTab/PullsTable/Coverage/Coverage.tsx 100.00% <100.00%> (ø)
...ges/RepoPage/PullsTab/PullsTable/Coverage/enums.ts 100.00% <ø> (ø)
.../pages/RepoPage/PullsTab/PullsTable/PullsTable.jsx 100.00% <ø> (ø)
...epoPage/PullsTab/PullsTableTeam/PullsTableTeam.tsx 100.00% <100.00%> (ø)
...llsTab/PullsTableTeam/createPullsTableTeamData.tsx 100.00% <100.00%> (ø)
src/pages/RepoPage/PullsTab/shared/Title/Title.tsx 100.00% <100.00%> (ø)
src/services/pulls/usePullsTeam.tsx 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8473e3...788a68d. Read the comment docs.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #2358 (788a68d) into main (e8473e3) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2358     +/-   ##
=======================================
- Coverage   97.15   97.07   -0.08     
=======================================
  Files        727     730      +3     
  Lines       8715    8774     +59     
  Branches    2112    2123     +11     
=======================================
+ Hits        8467    8517     +50     
- Misses       246     254      +8     
- Partials       2       3      +1     
Files Coverage Δ
src/pages/RepoPage/PullsTab/PullsTab.tsx 100.00% <100.00%> (ø)
...RepoPage/PullsTab/PullsTable/Coverage/Coverage.tsx 100.00% <100.00%> (ø)
...ges/RepoPage/PullsTab/PullsTable/Coverage/enums.ts 100.00% <ø> (ø)
.../pages/RepoPage/PullsTab/PullsTable/PullsTable.jsx 100.00% <ø> (ø)
...epoPage/PullsTab/PullsTableTeam/PullsTableTeam.tsx 100.00% <100.00%> (ø)
...llsTab/PullsTableTeam/createPullsTableTeamData.tsx 100.00% <100.00%> (ø)
src/pages/RepoPage/PullsTab/shared/Title/Title.tsx 100.00% <100.00%> (ø)
src/services/pulls/usePullsTeam.tsx 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8473e3...788a68d. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Oct 30, 2023

Codecov Report

Merging #2358 (788a68d) into main (e8473e3) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2358      +/-   ##
==========================================
- Coverage   97.15%   97.07%   -0.09%     
==========================================
  Files         727      730       +3     
  Lines        8715     8774      +59     
  Branches     2112     2125      +13     
==========================================
+ Hits         8467     8517      +50     
- Misses        246      254       +8     
- Partials        2        3       +1     
Files Coverage Δ
src/pages/RepoPage/PullsTab/PullsTab.tsx 100.00% <100.00%> (ø)
...RepoPage/PullsTab/PullsTable/Coverage/Coverage.tsx 100.00% <100.00%> (ø)
...ges/RepoPage/PullsTab/PullsTable/Coverage/enums.ts 100.00% <ø> (ø)
.../pages/RepoPage/PullsTab/PullsTable/PullsTable.jsx 100.00% <ø> (ø)
...epoPage/PullsTab/PullsTableTeam/PullsTableTeam.tsx 100.00% <100.00%> (ø)
...llsTab/PullsTableTeam/createPullsTableTeamData.tsx 100.00% <100.00%> (ø)
src/pages/RepoPage/PullsTab/shared/Title/Title.tsx 100.00% <100.00%> (ø)
src/services/pulls/usePullsTeam.tsx 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8473e3...788a68d. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Oct 30, 2023

Codecov Report

Merging #2358 (3e3c115) into main (89e4ea3) will increase coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 3e3c115 differs from pull request most recent head 788a68d. Consider uploading reports for the commit 788a68d to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2358      +/-   ##
==========================================
+ Coverage   97.15%   97.16%   +0.01%     
==========================================
  Files         727      728       +1     
  Lines        8706     8740      +34     
  Branches     2149     2158       +9     
==========================================
+ Hits         8458     8492      +34     
+ Misses        246      245       -1     
- Partials        2        3       +1     
Files Coverage Δ
src/pages/RepoPage/PullsTab/PullsTab.tsx 100.00% <100.00%> (ø)
...RepoPage/PullsTab/PullsTable/Coverage/Coverage.tsx 100.00% <100.00%> (ø)
...ges/RepoPage/PullsTab/PullsTable/Coverage/enums.ts 100.00% <ø> (ø)
.../pages/RepoPage/PullsTab/PullsTable/PullsTable.jsx 100.00% <ø> (ø)
...epoPage/PullsTab/PullsTableTeam/PullsTableTeam.tsx 100.00% <100.00%> (ø)
...llsTab/PullsTableTeam/createPullsTableTeamData.tsx 100.00% <100.00%> (ø)
src/pages/RepoPage/PullsTab/shared/Title/Title.tsx 100.00% <100.00%> (ø)
src/services/pulls/usePullsTeam.tsx 100.00% <100.00%> (ø)

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8473e3...788a68d. Read the comment docs.

@netlify
Copy link

netlify bot commented Oct 30, 2023

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 788a68d
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/654294d574cdaf0008dcf435
😎 Deploy Preview https://deploy-preview-2358--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nicholas-codecov nicholas-codecov merged commit 6250957 into main Nov 1, 2023
25 of 27 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-615-update-repo-page-pulls-list-tab branch November 1, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Client] - Repo Page Pulls Tab List: Add New Table For Team Tier
2 participants