Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Checks for Commit Detail Page and Coverage Tab Flag Multi Selects #2371

Merged

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR updates the condition checks for the commit detail page and coverage tab flag multi selects to render when the user on a team plan but the current repo is public.

Notable Changes

  • Update CommitDetailPageTabs to render always multi select on public repos
  • Update Fileviewer to always render multi select on public repos
  • Update FlagMultiSelect to always render on public repos
  • Update tests

Copy link

netlify bot commented Nov 2, 2023

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 83b6daa
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/6548c8e767b7cf0008d44027
😎 Deploy Preview https://deploy-preview-2371--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-staging
Copy link

codecov-staging bot commented Nov 2, 2023

Codecov Report

Merging #2371 (83b6daa) into main (906eee1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2371   +/-   ##
=======================================
  Coverage   96.27%   96.27%           
=======================================
  Files         736      736           
  Lines        8967     8970    +3     
  Branches     2231     2186   -45     
=======================================
+ Hits         8633     8636    +3     
- Misses        317      318    +1     
+ Partials       17       16    -1     
Files Coverage Δ
...Page/CommitDetailPageTabs/CommitDetailPageTabs.jsx 100.00% <100.00%> (ø)
...erageTab/subroute/FileExplorer/FlagMultiSelect.jsx 100.00% <100.00%> (ø)
...age/CoverageTab/subroute/Fileviewer/Fileviewer.jsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 906eee1...83b6daa. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Nov 2, 2023

Codecov Report

Merging #2371 (83b6daa) into main (906eee1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2371   +/-   ##
=======================================
  Coverage   96.27%   96.27%           
=======================================
  Files         736      736           
  Lines        8967     8970    +3     
  Branches     2231     2219   -12     
=======================================
+ Hits         8633     8636    +3     
+ Misses        318      317    -1     
- Partials       16       17    +1     
Files Coverage Δ
...Page/CommitDetailPageTabs/CommitDetailPageTabs.jsx 100.00% <100.00%> (ø)
...erageTab/subroute/FileExplorer/FlagMultiSelect.jsx 100.00% <100.00%> (ø)
...age/CoverageTab/subroute/Fileviewer/Fileviewer.jsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 906eee1...83b6daa. Read the comment docs.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #2371 (83b6daa) into main (906eee1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2371   +/-   ##
=====================================
  Coverage   96.28   96.28           
=====================================
  Files        736     736           
  Lines       8967    8970    +3     
  Branches    2236    2232    -4     
=====================================
+ Hits        8633    8636    +3     
  Misses       317     317           
  Partials      17      17           
Files Coverage Δ
...Page/CommitDetailPageTabs/CommitDetailPageTabs.jsx 100.00% <100.00%> (ø)
...erageTab/subroute/FileExplorer/FlagMultiSelect.jsx 100.00% <100.00%> (ø)
...age/CoverageTab/subroute/Fileviewer/Fileviewer.jsx 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 906eee1...83b6daa. Read the comment docs.

@nicholas-codecov nicholas-codecov merged commit 904e814 into main Nov 6, 2023
31 checks passed
@nicholas-codecov nicholas-codecov deleted the fix-flag-multi-selects-to-show-on-public-repos branch November 6, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants