Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Redirect on Flags Tab for Public Repos #2391

Merged

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR updates the FlagsTab to only redirect while an org is on a team plan and the repo is also public.

Closes codecov/engineering-team#781

Notable Changes

  • Update FlagsTab.jsx
  • Update tests

Copy link

netlify bot commented Nov 9, 2023

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 042ede4
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/654cfb1a9fc4c9000899b58d
😎 Deploy Preview https://deploy-preview-2391--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #2391 (042ede4) into main (bc1c05a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2391   +/-   ##
=====================================
  Coverage   96.15   96.15           
=====================================
  Files        748     748           
  Lines       9325    9326    +1     
  Branches    2319    2319           
=====================================
+ Hits        8966    8967    +1     
  Misses       341     341           
  Partials      18      18           
Files Coverage Δ
src/pages/RepoPage/FlagsTab/FlagsTab.jsx 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc1c05a...042ede4. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Nov 9, 2023

Codecov Report

Merging #2391 (042ede4) into main (bc1c05a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2391   +/-   ##
=======================================
  Coverage   96.15%   96.15%           
=======================================
  Files         748      748           
  Lines        9325     9326    +1     
  Branches     2332     2332           
=======================================
+ Hits         8966     8967    +1     
- Misses        341      343    +2     
+ Partials       18       16    -2     
Files Coverage Δ
src/pages/RepoPage/FlagsTab/FlagsTab.jsx 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc1c05a...042ede4. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Nov 9, 2023

Codecov Report

Merging #2391 (042ede4) into main (bc1c05a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2391   +/-   ##
=======================================
  Coverage   96.15%   96.15%           
=======================================
  Files         748      748           
  Lines        9325     9326    +1     
  Branches     2332     2337    +5     
=======================================
+ Hits         8966     8967    +1     
  Misses        341      341           
  Partials       18       18           
Files Coverage Δ
src/pages/RepoPage/FlagsTab/FlagsTab.jsx 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc1c05a...042ede4. Read the comment docs.

@nicholas-codecov nicholas-codecov merged commit 56c0992 into main Nov 9, 2023
31 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-781-fix-redirect-on-flag-tab-for-public-repos branch November 9, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Client] Get rid of redicrect when it's a public repo on Flag tab
2 participants