-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Hide expired banner when clicking on upgrade link #2398
feat: Hide expired banner when clicking on upgrade link #2398
Conversation
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## main #2398 +/- ##
=======================================
Coverage 96.18% 96.18%
=======================================
Files 750 750
Lines 9406 9411 +5
Branches 2364 2364
=======================================
+ Hits 9047 9052 +5
Misses 341 341
Partials 18 18
Continue to review full report in Codecov by Sentry.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2398 +/- ##
=======================================
Coverage 96.18% 96.18%
=======================================
Files 750 750
Lines 9406 9411 +5
Branches 2369 2369
=======================================
+ Hits 9047 9052 +5
Misses 341 341
Partials 18 18
Continue to review full report in Codecov by Sentry.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2398 +/- ##
=======================================
+ Coverage 96.18 96.19 +0.01
=======================================
Files 750 750
Lines 9406 9411 +5
Branches 2318 2320 +2
=======================================
+ Hits 9047 9052 +5
Misses 343 343
Partials 16 16
Continue to review full report in Codecov by Sentry.
|
Description
This PR adds an
onClick
event to the upgrade button in theExpiredBanner
that saves the value to the local storage. This is a little hacky because it's reliant on the navigation to update the state when returning to the previous page to actually hide the banner because there's no real way to update the state from theExpiredBanner
component itself.Closes codecov/engineering-team#746
Notable Changes
ExpiredBanner
TopBanner