Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix analytics page chart selector behavior #2400

Conversation

rohitvinnakota-codecov
Copy link
Contributor

Description

This PR closes codecov/engineering-team#785. If the user is on a team plan, we only want to show them public repos on the analytics page. Adds similar logic as the one in the table below to filter public repositories.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@rohitvinnakota-codecov rohitvinnakota-codecov changed the title team plan filter in chart selectors Fix analytics page chart selector behavior Nov 14, 2023
Copy link

netlify bot commented Nov 14, 2023

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit cc3436a
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/6553bca747136600089f34f2
😎 Deploy Preview https://deploy-preview-2400--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-staging
Copy link

codecov-staging bot commented Nov 14, 2023

Codecov Report

Merging #2400 (7b09271) into main (9b40b19) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2400   +/-   ##
=======================================
  Coverage   96.19%   96.19%           
=======================================
  Files         750      750           
  Lines        9417     9419    +2     
  Branches     2367     2368    +1     
=======================================
+ Hits         9059     9061    +2     
  Misses        340      340           
  Partials       18       18           
Files Coverage Δ
...es/AnalyticsPage/ChartSelectors/ChartSelectors.jsx 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b40b19...7b09271. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Nov 14, 2023

Codecov Report

Merging #2400 (7b09271) into main (9b40b19) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2400   +/-   ##
=======================================
  Coverage   96.19%   96.19%           
=======================================
  Files         750      750           
  Lines        9417     9419    +2     
  Branches     2323     2324    +1     
=======================================
+ Hits         9059     9061    +2     
  Misses        342      342           
  Partials       16       16           
Files Coverage Δ
...es/AnalyticsPage/ChartSelectors/ChartSelectors.jsx 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b40b19...7b09271. Read the comment docs.

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #2400 (7b09271) into main (9b40b19) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2400   +/-   ##
=====================================
  Coverage   96.20   96.20           
=====================================
  Files        750     750           
  Lines       9417    9419    +2     
  Branches    2354    2324   -30     
=====================================
+ Hits        9059    9061    +2     
- Misses       340     342    +2     
+ Partials      18      16    -2     
Files Coverage Δ
...es/AnalyticsPage/ChartSelectors/ChartSelectors.jsx 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b40b19...7b09271. Read the comment docs.

Copy link

netlify bot commented Nov 14, 2023

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 7b09271
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/6553bcc2678f6d00088aa50b
😎 Deploy Preview https://deploy-preview-2400--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rohitvinnakota-codecov rohitvinnakota-codecov marked this pull request as ready for review November 14, 2023 18:40
@rohitvinnakota-codecov rohitvinnakota-codecov merged commit 5d10549 into main Nov 14, 2023
31 checks passed
@rohitvinnakota-codecov rohitvinnakota-codecov deleted the rvinnakota/Fix-analytics-page-chart-selector-behavior branch November 14, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Client] Fix analytics page chart selector behavior
2 participants