[Client] Add logic to return measurements data based on specifying public and private repo #2402
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2402 +/- ##
=======================================
Coverage 96.23% 96.23%
=======================================
Files 750 750
Lines 9431 9433 +2
Branches 2324 2327 +3
=======================================
+ Hits 9076 9078 +2
Misses 340 340
Partials 15 15
Continue to review full report in Codecov by Sentry.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2402 +/- ##
=====================================
Coverage 96.24 96.24
=====================================
Files 750 750
Lines 9431 9433 +2
Branches 2370 2358 -12
=====================================
+ Hits 9076 9078 +2
Misses 338 338
Partials 17 17
Continue to review full report in Codecov by Sentry.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2402 +/- ##
=======================================
Coverage 96.23% 96.23%
=======================================
Files 750 750
Lines 9431 9433 +2
Branches 2375 2371 -4
=======================================
+ Hits 9076 9078 +2
- Misses 338 340 +2
+ Partials 17 15 -2
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
||
| import { useCoverage } from './useCoverage' | ||
|
|
||
| jest.mock('services/charts') | ||
| jest.mock('react-router-dom', () => ({ |
There was a problem hiding this comment.
This is an antipattern we used to do back in the day we're trying to replace. Effectively this is mocking useParams so that jest doesn't complain, but we can also rightfully provide it to emulate the router, take a look at this test for example, https://github.com/codecov/gazebo/blob/main/src/services/trial/useStartTrial.spec.tsx#L23. Could you get rid of this mock and instead provide the route parameters, seems like owner and provider, to the request instead? Lmk if you have a question
rohitvinnakota-codecov
deleted the
rvinnakota/add-public-field-measurements
branch
Description
Make the line chart on the Analytics page filter on only public repos if the user is on a team plan. This makes use of the new
isPublicparameter on the measurements GQL field as added in codecov/engineering-team#786. This PR closes codecov/engineering-team#787.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.