Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert some more of pull request details page to TS #2414

Merged
merged 6 commits into from
Nov 23, 2023

Conversation

terry-codecov
Copy link
Contributor

Description

Not much to say, just converting over more JS files. Looks like #145 is actually API work so there will be another gazebo follow up pr passing that setting when it exists.

Code Example

Notable Changes

Screenshots

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Merging #2414 (ae3da80) into main (021e6a7) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2414   +/-   ##
=====================================
  Coverage   96.24   96.24           
=====================================
  Files        751     751           
  Lines       9448    9450    +2     
  Branches    2332    2379   +47     
=====================================
+ Hits        9093    9095    +2     
  Misses       340     340           
  Partials      15      15           
Files Coverage Δ
...PullRequestPage/subroute/CommitsTab/CommitsTab.tsx 100.00% <100.00%> (ø)
...e/subroute/CommitsTab/shared/CIStatus/CIStatus.tsx 100.00% <100.00%> (ø)
...estPage/subroute/CommitsTab/shared/Title/Title.tsx 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 021e6a7...ae3da80. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Nov 21, 2023

Codecov Report

Merging #2414 (ae3da80) into main (021e6a7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2414   +/-   ##
=======================================
  Coverage   96.24%   96.24%           
=======================================
  Files         751      751           
  Lines        9448     9450    +2     
  Branches     2334     2379   +45     
=======================================
+ Hits         9093     9095    +2     
  Misses        340      340           
  Partials       15       15           
Files Coverage Δ
...PullRequestPage/subroute/CommitsTab/CommitsTab.tsx 100.00% <100.00%> (ø)
...e/subroute/CommitsTab/shared/CIStatus/CIStatus.tsx 100.00% <100.00%> (ø)
...estPage/subroute/CommitsTab/shared/Title/Title.tsx 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 021e6a7...ae3da80. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Nov 21, 2023

Codecov Report

Merging #2414 (ae3da80) into main (021e6a7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2414   +/-   ##
=======================================
  Coverage   96.24%   96.24%           
=======================================
  Files         751      751           
  Lines        9448     9450    +2     
  Branches     2332     2384   +52     
=======================================
+ Hits         9093     9095    +2     
+ Misses        340      338    -2     
- Partials       15       17    +2     
Files Coverage Δ
...PullRequestPage/subroute/CommitsTab/CommitsTab.tsx 100.00% <100.00%> (ø)
...e/subroute/CommitsTab/shared/CIStatus/CIStatus.tsx 100.00% <100.00%> (ø)
...estPage/subroute/CommitsTab/shared/Title/Title.tsx 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 021e6a7...ae3da80. Read the comment docs.

Copy link

netlify bot commented Nov 23, 2023

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit ae3da80
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/655f886e8f3da3000891ed5b
😎 Deploy Preview https://deploy-preview-2414--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@RulaKhaled RulaKhaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, left a comment

@nicholas-codecov nicholas-codecov merged commit 4994e3d into main Nov 23, 2023
31 checks passed
@nicholas-codecov nicholas-codecov deleted the 145-commits-list branch November 23, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants