-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert some more of pull request details page to TS #2414
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2414 +/- ##
=====================================
Coverage 96.24 96.24
=====================================
Files 751 751
Lines 9448 9450 +2
Branches 2332 2379 +47
=====================================
+ Hits 9093 9095 +2
Misses 340 340
Partials 15 15
Continue to review full report in Codecov by Sentry.
|
Codecov Report
@@ Coverage Diff @@
## main #2414 +/- ##
=======================================
Coverage 96.24% 96.24%
=======================================
Files 751 751
Lines 9448 9450 +2
Branches 2334 2379 +45
=======================================
+ Hits 9093 9095 +2
Misses 340 340
Partials 15 15
Continue to review full report in Codecov by Sentry.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2414 +/- ##
=======================================
Coverage 96.24% 96.24%
=======================================
Files 751 751
Lines 9448 9450 +2
Branches 2332 2384 +52
=======================================
+ Hits 9093 9095 +2
+ Misses 340 338 -2
- Partials 15 17 +2
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
src/pages/PullRequestPage/subroute/CommitsTab/shared/CIStatus/CIStatus.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, left a comment
Description
Not much to say, just converting over more JS files. Looks like #145 is actually API work so there will be another gazebo follow up pr passing that setting when it exists.
Code Example
Notable Changes
Screenshots
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.