Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update indirect changed tab with components selector #2431

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

RulaKhaled
Copy link
Contributor

Description

Update indirect changed tab with components selector

Notable Changes

  • Add the selector to the tab
  • tests
  • update hook to accept filters
  • update flaky tests

Screenshots

tbd

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-qa
Copy link

codecov-qa bot commented Nov 29, 2023

Codecov Report

Merging #2431 (88e430c) into main (1bfca2c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2431   +/-   ##
=======================================
  Coverage   97.89%   97.89%           
=======================================
  Files         762      762           
  Lines        9674     9676    +2     
  Branches     2420     2435   +15     
=======================================
+ Hits         9470     9472    +2     
  Misses        202      202           
  Partials        2        2           
Files Coverage Δ
...ChangedFiles/hooks/useIndirectChangedFilesTable.js 100.00% <100.00%> (ø)
...gesTab/IndirectChangesInfo/IndirectChangesInfo.jsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 97.30% <ø> (ø)
Pages 98.92% <100.00%> (+<0.01%) ⬆️
Services 99.42% <ø> (ø)
Shared 99.81% <ø> (ø)
UI 94.32% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bfca2c...88e430c. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Nov 29, 2023

Codecov Report

Merging #2431 (bdc5985) into main (429eecf) will increase coverage by 0.00%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2431   +/-   ##
=======================================
  Coverage   97.90%   97.90%           
=======================================
  Files         758      760    +2     
  Lines        9587     9643   +56     
  Branches     2400     2424   +24     
=======================================
+ Hits         9386     9441   +55     
- Misses        199      200    +1     
  Partials        2        2           
Files Coverage Δ
...subroute/ComponentsSelector/ComponentsSelector.tsx 100.00% <100.00%> (ø)
...ChangedFiles/hooks/useIndirectChangedFilesTable.js 100.00% <100.00%> (ø)
...gesTab/IndirectChangesInfo/IndirectChangesInfo.jsx 100.00% <ø> (ø)

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 429eecf...bdc5985. Read the comment docs.

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #2431 (88e430c) into main (1bfca2c) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2431   +/-   ##
=====================================
  Coverage   97.89   97.89           
=====================================
  Files        762     762           
  Lines       9674    9676    +2     
  Branches    2439    2435    -4     
=====================================
+ Hits        9470    9472    +2     
  Misses       202     202           
  Partials       2       2           
Files Coverage Δ
...ChangedFiles/hooks/useIndirectChangedFilesTable.js 100.00% <100.00%> (ø)
...gesTab/IndirectChangesInfo/IndirectChangesInfo.jsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 97.30% <ø> (ø)
Pages 98.92% <100.00%> (+<0.01%) ⬆️
Services 99.42% <ø> (ø)
Shared 99.81% <ø> (ø)
UI 94.32% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bfca2c...88e430c. Read the comment docs.

Copy link

netlify bot commented Nov 29, 2023

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 88e430c
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/6576ee1fd7b7fa0008aa901c
😎 Deploy Preview https://deploy-preview-2431--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@RulaKhaled RulaKhaled marked this pull request as ready for review December 2, 2023 11:35
Copy link
Contributor

@JerrySentry JerrySentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov-public-qa bot commented Dec 11, 2023

Codecov Report

Merging #2431 (88e430c) into main (1bfca2c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2431   +/-   ##
=======================================
  Coverage   97.89%   97.89%           
=======================================
  Files         762      762           
  Lines        9674     9676    +2     
  Branches     2420     2391   -29     
=======================================
+ Hits         9470     9472    +2     
  Misses        202      202           
  Partials        2        2           
Files Coverage Δ
...ChangedFiles/hooks/useIndirectChangedFilesTable.js 100.00% <100.00%> (ø)
...gesTab/IndirectChangesInfo/IndirectChangesInfo.jsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 97.30% <ø> (ø)
Pages 98.92% <100.00%> (+<0.01%) ⬆️
Services 99.42% <ø> (ø)
Shared 99.81% <ø> (ø)
UI 94.32% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bfca2c...88e430c. Read the comment docs.

@RulaKhaled RulaKhaled merged commit 24b16cb into main Dec 11, 2023
50 checks passed
@RulaKhaled RulaKhaled deleted the support-selector-in-indirect-changes branch December 11, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants