-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add default branch specifc message to file explorer in coverage page #2458
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2458 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 777 777
Lines 9994 9996 +2
Branches 2555 2537 -18
=======================================
+ Hits 9808 9810 +2
Misses 184 184
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2458 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 777 777
Lines 9994 9996 +2
Branches 2504 2537 +33
=======================================
+ Hits 9808 9810 +2
Misses 184 184
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2458 +/- ##
=====================================
Coverage 98.14 98.14
=====================================
Files 777 777
Lines 9994 9996 +2
Branches 2506 2507 +1
=====================================
+ Hits 9808 9810 +2
Misses 184 184
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing to take a peak at
@@ -0,0 +1,41 @@ | |||
interface RepoContentsProps { | |||
isSearching: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it should be a boolean
looking at the old prop types?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good to me, thanks for those quick fixes 👍
Description
We're adjusting the message thrown in the coverage tab when we are unable to find data for the customer to look into swapping a branch.
GH Issue: codecov/engineering-team#871
Notable Changes
RepoContentsResult
to signal change to the default branchScreenshots
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.