Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add default branch specifc message to file explorer in coverage page #2458

Merged
merged 4 commits into from
Dec 14, 2023

Conversation

adrian-codecov
Copy link
Contributor

Description

We're adjusting the message thrown in the coverage tab when we are unable to find data for the customer to look into swapping a branch.

GH Issue: codecov/engineering-team#871

Notable Changes

  • Adjust the message in RepoContentsResult to signal change to the default branch
    • Make that file a TS file
  • Adjust tests

Screenshots

Screenshot 2023-12-13 at 4 36 51 PM

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov-public-qa bot commented Dec 13, 2023

Codecov Report

Merging #2458 (aa098cb) into main (b56855d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2458   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files         777      777           
  Lines        9994     9996    +2     
  Branches     2555     2537   -18     
=======================================
+ Hits         9808     9810    +2     
  Misses        184      184           
  Partials        2        2           
Files Coverage Δ
...ubroute/FileExplorer/shared/RepoContentsResult.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 97.30% <ø> (ø)
Pages 98.99% <100.00%> (+<0.01%) ⬆️
Services 99.44% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.33% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b56855d...aa098cb. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Dec 13, 2023

Codecov Report

Merging #2458 (aa098cb) into main (b56855d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2458   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files         777      777           
  Lines        9994     9996    +2     
  Branches     2504     2537   +33     
=======================================
+ Hits         9808     9810    +2     
  Misses        184      184           
  Partials        2        2           
Files Coverage Δ
...ubroute/FileExplorer/shared/RepoContentsResult.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 97.30% <ø> (ø)
Pages 98.99% <100.00%> (+<0.01%) ⬆️
Services 99.44% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.33% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b56855d...aa098cb. Read the comment docs.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #2458 (aa098cb) into main (b56855d) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2458   +/-   ##
=====================================
  Coverage   98.14   98.14           
=====================================
  Files        777     777           
  Lines       9994    9996    +2     
  Branches    2506    2507    +1     
=====================================
+ Hits        9808    9810    +2     
  Misses       184     184           
  Partials       2       2           
Files Coverage Δ
...ubroute/FileExplorer/shared/RepoContentsResult.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 97.30% <ø> (ø)
Pages 98.99% <100.00%> (+<0.01%) ⬆️
Services 99.44% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.33% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b56855d...aa098cb. Read the comment docs.

Copy link

netlify bot commented Dec 13, 2023

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit aa098cb
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/657b30bd975cbc00081d8ac3
😎 Deploy Preview https://deploy-preview-2458--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to take a peak at

@@ -0,0 +1,41 @@
interface RepoContentsProps {
isSearching: string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it should be a boolean looking at the old prop types?

Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me, thanks for those quick fixes 👍

@adrian-codecov adrian-codecov merged commit c2b1e63 into main Dec 14, 2023
50 checks passed
@adrian-codecov adrian-codecov deleted the 871-default-branch-default-error branch December 14, 2023 16:56
adrian-codecov added a commit that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants