Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make flag entries links #2468

Merged
merged 3 commits into from
Dec 21, 2023
Merged

Conversation

adrian-codecov
Copy link
Contributor

Description

This PR makes entries in the flags page link to their selected flag in the coverage page.

Closes codecov/engineering-team#847

Notable Changes

  • Added new link for the coverage page that accepts query params
  • Made flag names link to the coverage page

Screenshots

screen-capture.13.webm

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov-public-qa bot commented Dec 20, 2023

Codecov Report

Merging #2468 (7828072) into main (ea1f29b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2468   +/-   ##
=======================================
  Coverage   98.14%   98.14%           
=======================================
  Files         778      778           
  Lines       10026    10032    +6     
  Branches     2558     2546   -12     
=======================================
+ Hits         9840     9846    +6     
  Misses        184      184           
  Partials        2        2           
Files Coverage Δ
...poPage/FlagsTab/subroute/FlagsTable/FlagsTable.jsx 100.00% <ø> (ø)
src/services/navigation/useNavLinks/useNavLinks.js 99.05% <100.00%> (+0.02%) ⬆️
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 97.30% <ø> (ø)
Pages 98.99% <ø> (ø)
Services 99.44% <100.00%> (+<0.01%) ⬆️
Shared 99.82% <ø> (ø)
UI 94.32% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea1f29b...7828072. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2468   +/-   ##
=======================================
  Coverage   98.14%   98.14%           
=======================================
  Files         778      778           
  Lines       10026    10032    +6     
  Branches     2558     2514   -44     
=======================================
+ Hits         9840     9846    +6     
  Misses        184      184           
  Partials        2        2           
Files Coverage Δ
...poPage/FlagsTab/subroute/FlagsTable/FlagsTable.jsx 100.00% <ø> (ø)
src/services/navigation/useNavLinks/useNavLinks.js 99.05% <100.00%> (+0.02%) ⬆️
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 97.30% <ø> (ø)
Pages 98.99% <ø> (ø)
Services 99.44% <100.00%> (+<0.01%) ⬆️
Shared 99.82% <ø> (ø)
UI 94.32% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea1f29b...7828072. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea1f29b) 98.14% compared to head (7828072) 98.14%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2468   +/-   ##
=======================================
  Coverage   98.14%   98.14%           
=======================================
  Files         778      778           
  Lines       10026    10032    +6     
  Branches     2514     2516    +2     
=======================================
+ Hits         9840     9846    +6     
  Misses        184      184           
  Partials        2        2           
Files Coverage Δ
...poPage/FlagsTab/subroute/FlagsTable/FlagsTable.jsx 100.00% <ø> (ø)
src/services/navigation/useNavLinks/useNavLinks.js 99.05% <100.00%> (+0.02%) ⬆️
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 97.30% <ø> (ø)
Pages 98.99% <ø> (ø)
Services 99.44% <100.00%> (+<0.01%) ⬆️
Shared 99.82% <ø> (ø)
UI 94.32% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea1f29b...7828072. Read the comment docs.

Copy link

netlify bot commented Dec 20, 2023

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 7828072
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/6583828c5c31bf0008a27249
😎 Deploy Preview https://deploy-preview-2468--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea1f29b) 98.14% compared to head (7828072) 98.15%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2468     +/-   ##
=======================================
+ Coverage   98.14   98.15   +0.01     
=======================================
  Files        778     778             
  Lines      10026   10032      +6     
  Branches    2558    2546     -12     
=======================================
+ Hits        9840    9846      +6     
  Misses       184     184             
  Partials       2       2             
Files Coverage Δ
...poPage/FlagsTab/subroute/FlagsTable/FlagsTable.jsx 100.00% <ø> (ø)
src/services/navigation/useNavLinks/useNavLinks.js 99.05% <100.00%> (+0.02%) ⬆️
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 97.30% <ø> (ø)
Pages 98.99% <ø> (ø)
Services 99.44% <100.00%> (+<0.01%) ⬆️
Shared 99.82% <ø> (ø)
UI 94.32% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea1f29b...7828072. Read the comment docs.

Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one quick thing to take a peak at

@@ -243,6 +258,29 @@ describe('RepoContentsTable', () => {
})
})

describe.only('flag name is clicked', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should remove this .only 👀

Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Send it

@adrian-codecov adrian-codecov merged commit 89369b4 into main Dec 21, 2023
58 checks passed
@adrian-codecov adrian-codecov deleted the 847-link-flags-to-coverage-page branch December 21, 2023 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link to flags filter on Coverage tab from Flags tab
2 participants