-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make flag entries links #2468
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2468 +/- ##
=======================================
Coverage 98.14% 98.14%
=======================================
Files 778 778
Lines 10026 10032 +6
Branches 2558 2546 -12
=======================================
+ Hits 9840 9846 +6
Misses 184 184
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #2468 +/- ##
=======================================
Coverage 98.14% 98.14%
=======================================
Files 778 778
Lines 10026 10032 +6
Branches 2558 2514 -44
=======================================
+ Hits 9840 9846 +6
Misses 184 184
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2468 +/- ##
=======================================
Coverage 98.14% 98.14%
=======================================
Files 778 778
Lines 10026 10032 +6
Branches 2514 2516 +2
=======================================
+ Hits 9840 9846 +6
Misses 184 184
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2468 +/- ##
=======================================
+ Coverage 98.14 98.15 +0.01
=======================================
Files 778 778
Lines 10026 10032 +6
Branches 2558 2546 -12
=======================================
+ Hits 9840 9846 +6
Misses 184 184
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one quick thing to take a peak at
@@ -243,6 +258,29 @@ describe('RepoContentsTable', () => { | |||
}) | |||
}) | |||
|
|||
describe.only('flag name is clicked', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably should remove this .only
👀
…k-flags-to-coverage-page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Send it
Description
This PR makes entries in the flags page link to their selected flag in the coverage page.
Closes codecov/engineering-team#847
Notable Changes
Screenshots
screen-capture.13.webm
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.