Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Plan user count can be a nullable value #2485

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

nicholas-codecov
Copy link
Contributor

Description

planUserCount can be a null value so we need to set it to be nullable in our zod schema.

Copy link

netlify bot commented Jan 4, 2024

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit a39650a
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/6596b4b1fd5bd80008f31926
😎 Deploy Preview https://deploy-preview-2485--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov-public-qa bot commented Jan 4, 2024

Codecov Report

Merging #2485 (a39650a) into main (c724284) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2485   +/-   ##
=======================================
  Coverage   98.25%   98.25%           
=======================================
  Files         772      772           
  Lines        9847     9847           
  Branches     2514     2470   -44     
=======================================
  Hits         9675     9675           
  Misses        170      170           
  Partials        2        2           
Files Coverage Δ
src/services/account/usePlanData.ts 100.00% <ø> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 97.30% <ø> (ø)
Pages 99.23% <ø> (ø)
Services 99.44% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.32% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c724284...a39650a. Read the comment docs.

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c724284) 98.25% compared to head (a39650a) 98.25%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2485   +/-   ##
=====================================
  Coverage   98.25   98.25           
=====================================
  Files        772     772           
  Lines       9847    9847           
  Branches    2468    2470    +2     
=====================================
  Hits        9675    9675           
  Misses       170     170           
  Partials       2       2           
Files Coverage Δ
src/services/account/usePlanData.ts 100.00% <ø> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 97.30% <ø> (ø)
Pages 99.23% <ø> (ø)
Services 99.44% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.32% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c724284...a39650a. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c724284) 98.25% compared to head (a39650a) 98.25%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2485   +/-   ##
=======================================
  Coverage   98.25%   98.25%           
=======================================
  Files         772      772           
  Lines        9847     9847           
  Branches     2514     2519    +5     
=======================================
  Hits         9675     9675           
  Misses        170      170           
  Partials        2        2           
Files Coverage Δ
src/services/account/usePlanData.ts 100.00% <ø> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 97.30% <ø> (ø)
Pages 99.23% <ø> (ø)
Services 99.44% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.32% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c724284...a39650a. Read the comment docs.

@codecov-staging
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2485   +/-   ##
=======================================
  Coverage   98.25%   98.25%           
=======================================
  Files         772      772           
  Lines        9847     9847           
  Branches     2500     2519   +19     
=======================================
  Hits         9675     9675           
  Misses        170      170           
  Partials        2        2           
Files Coverage Δ
src/services/account/usePlanData.ts 100.00% <ø> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 97.30% <ø> (ø)
Pages 99.23% <ø> (ø)
Services 99.44% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.32% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c724284...a39650a. Read the comment docs.

@nicholas-codecov nicholas-codecov merged commit 6359d13 into main Jan 4, 2024
58 checks passed
@nicholas-codecov nicholas-codecov deleted the fix-plan-user-count-can-be-nullable branch January 4, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants